fix: less often remount on scrollview#1
Open
WoLewicki wants to merge 1 commit into
Open
Conversation
On the New Architecture (Fabric), Reanimated commits the shadow tree ~once per animation frame, and each mount transaction unconditionally called _remountChildren, re-clipping the entire descendant subtree even when nothing scrolled or changed layout. Guard _remountChildren with RCTMountingTransactionAffectsClipping, which returns YES only when the transaction can change clipping: an Insert/Remove mutation, an Update with changed layoutMetrics, or an Update toggling removeClippedSubviews. maintainVisibleContentPosition is unaffected since _adjustForMaintainVisibleContentPosition still runs on every mount. Moves the change from the React-RCTFabric local pod patch (discord/discord#292855) directly into the RN fork.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the New Architecture (Fabric), Reanimated commits the shadow tree ~once per animation frame, and each mount transaction unconditionally called
_remountChildren, re-clipping the entire descendant subtree even when nothing scrolled or changed layout.Guard
_remountChildrenwithRCTMountingTransactionAffectsClipping, which returnsYESonly when the transaction can change clipping: anInsert/Removemutation, an Update with changedlayoutMetrics, or anUpdatetogglingremoveClippedSubviews. maintainVisibleContentPosition is unaffected since_adjustForMaintainVisibleContentPositionstill runs on every mount.Moves the change from the React-RCTFabric local pod patch (discord/discord#292855) directly into the RN fork.