Conversation
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
Preview for PR #28 |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the version compatibility logic in the client connection code to support version 2.8.0 of the API, adding more granular version checking that includes the fourth version component (build number).
Key Changes:
- Updated the version check to distinguish between versions 2.7.5 and 2.8.0 using build number thresholds
- Added additional version checking logic for version 2.7.4 variants based on build numbers
- Updated command version assignment based on more precise version criteria
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| temp = version[2] + version[1] * 1000 + version[0] * 1000000 | ||
| if temp >= 2007005: | ||
| ## version after 2.7.5 | ||
| if (temp >= 2007005 and version[3] < 11274) or temp >= 2008000: |
There was a problem hiding this comment.
The magic number 11274 lacks explanation. Add a comment explaining why this specific build number is the threshold for version 2.7.5, or define it as a named constant for clarity.
| elif temp >= 2007004: | ||
| ## version after 2.7.4 | ||
| self.commandVersion = 13 | ||
| if version[3] < 10590: |
There was a problem hiding this comment.
The magic number 10590 lacks explanation. Add a comment explaining why this specific build number is the threshold for version 2.7.4, or define it as a named constant for clarity.
3 participants
Changed version