Open
Conversation
teto
reviewed
Jun 25, 2018
Member
teto
left a comment
teto
left a comment
There was a problem hiding this comment.
this increases the maintainance burden for little advantage, what does fping bring that ping doesn't have TCP pings ? I would vote for a mention about the dce_gettimeofday in the wiki instead. @thehajime what do you think ?
| NS_LOG_FUNCTION (Current () << UtilsGetNodeId ()); | ||
| NS_ASSERT (Current () != 0); | ||
| NS_ASSERT (tz == 0); | ||
| // NS_ASSERT (tz == 0); |
Member
There was a problem hiding this comment.
I am annoyed by this as it might hide problems for other programs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch enables fping support in DCE.
In order to run fping successfully an ASSERT (tz == 0) has to be disable inside getitmeofday function in dce.cc.
This ASSERT function doesn't allow application to extract timezone value from DCE.
If any application try to do DCE stops the execution of the application and the simulation as well.
Disabling this ASSERT work for fping because, though fping ask for timezone but never uses it.