Fixed ngModel issue when its used as inline. #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When this directive was used with inline option, the ngModel variable was not updating after selection of date/time. - Fixed the directive so that we can get updated value in ngModel variable after selection. - Updated example.html to show how to use inline with ngModel. This may be not the best approach to fix the issue, but its just a quick fix for those who want to use it right way.
|
https://github.com/dvdcxn/angular-bootstrap-datetimepicker-directive I forked it and bound the ng-model value to the moment date rather than the string of what is selected. This is just preferable for me as I'm providing it a moment object in the first place, it's nice for consistency. Plus, it seems like the datetimepicker "thinks" in moment, so it's a bit more consistent in that regard. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When this directive was used with inline option, the ngModel variable
was not updating after selection of date/time.
after selection.
This may be not the best approach to fix the issue, but its just a quick fix for those
who want to use it right way.