Open
Conversation
im-0
force-pushed
the
update-rand
branch
2 times, most recently
from
41427cc to
7403e3f
Compare
Author
|
I renamed new macro to not shadow the old one.
|
Implementations of `Distribution<T> for StandardUniform` for all SIMD types containing `isize` and `usize` now generate random values using `fill_bytes()`. Uniform distribution for `isize` and `usize` was removed from `rand` crate. See rust-random/rand#1487 for details. There is a new `UniformUsize` distribution, but it is limited to a maximum value under u32::MAX for portability across 32/64bits and for use as array indexes and lengths. Probably it is not suitable if a real uniform distribution is required.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementations of
Distribution<T> for StandardUniformfor all SIMD types containingisizeandusizenow generate random values usingfill_bytes().Uniform distribution for
isizeandusizewas removed fromrandcrate. See rust-random/rand#1487 for details.There is a new
UniformUsizedistribution, but it is limited to a maximum value under u32::MAX for portability across 32/64bits and for use as array indexes and lengths. Probably it is not suitable if a real uniform distribution is required.Note that this is a breaking change.
nalgebraalready updatedrandto0.9in dimforge/nalgebra@2da148c.