Conversation
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (73.91%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #912 +/- ##
==========================================
- Coverage 97.35% 97.33% -0.02%
==========================================
Files 50 50
Lines 20917 21119 +202
Branches 639 639
==========================================
+ Hits 20363 20557 +194
- Misses 489 497 +8
Partials 65 65 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mtorpey
left a comment
mtorpey
left a comment
There was a problem hiding this comment.
This has the right basic form, but needs to be corrected a bit. See my comments below.
| "consider encoding in Disparse6 or Digraph6"); | ||
| elif not IsSymmetricDigraph(D) then | ||
| ErrorNoReturn("the argument <D> must be a symmetric digraph; ", | ||
| "consider encoding in Sparse6 or Disparse6"); | ||
| elif DigraphHasLoops(D) then | ||
| ErrorNoReturn("the argument <D> must not have loops; ", | ||
| "consider encoding in Sparse6 or Disparse6"); |
There was a problem hiding this comment.
I think all three of these "consider" lines are wrong. Revise this with Wilf's summary from his issue:
Graph6: can encode any symmetric digraph without loops or multiple edges
Sparse6: can encode any symmetric digraph
Digraph6: can encode any digraph without multiple edges
Disparse6: can encode any digraph
| Error, the argument <D> must be a symmetric digraph with no loops or multiple \ | ||
| edges, | ||
| Error, the argument <D> must be a symmetric digraph; consider encoding in Spar\ | ||
| se6 or Disparse6 | ||
| gap> OnBreak := oldOnBreak;; |
There was a problem hiding this comment.
The fact these break across lines is probably an argument for putting \n after the semicolon. Could you do this in all cases?
|
Azure Pipelines: 1 pipeline(s) were filtered out due to trigger conditions. |
2 participants
Addressing the latter part of #47 , makes it so that it is now impossible to encode a digraph into an improper format(ex: a graph with multiple edges into Digraph6) and also recommends alternatives for a proper encoding in the error message.