Skip to content

Fixed some spot instance bugs. #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dwyerk wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed some spot instance bugs. #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 21 additions & 3 deletions cloud/providers/ec2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
from cloud.storage import JsonVolumeSpecManager
from cloud.storage import MountableVolume
from cloud.storage import Storage
from cloud.exception import VolumesStillInUseException
from cloud.exception import VolumesStillInUseException, InvalidSpotConfigurationException
from cloud.util import xstr
from cloud.util import get_ec2_connection
from cloud.util import log_cluster_action
Expand Down Expand Up @@ -316,8 +316,9 @@ def launch_instances(self, roles, number, image_id, size_id,
kernel_id=kwargs.get('kernel_id', None),
ramdisk_id=kwargs.get('ramdisk_i', None),
monitoring_enabled=kwargs.get('monitoring_enabled', False),
subnet_id=kwargs.get('subnet_id', None))
return [instance_request.id for instance_request in results]
subnet_id=kwargs.get('subnet_id', None))
#return [instance_request.id for instance_request in results]
return self.wait_for_spot_instances(results)

else:
reservation = self.ec2Connection.run_instances(image_id, min_count=number,
Expand All @@ -326,6 +327,23 @@ def launch_instances(self, roles, number, image_id, size_id,
instance_type=size_id, placement=kwargs.get('placement', None))
return [instance.id for instance in reservation.instances]

@timeout(600)
def wait_for_spot_instances(self, spot_requests):
wait_time = 3
ids = [spot_request.id for spot_request in spot_requests]
while True:
try:
active_requests = self.ec2Connection.get_all_spot_instance_requests(ids)
if self._all_active(active_requests):
break
except EC2ResponseError, e:
pass
time.sleep(wait_time)
return [i.instance_id for i in active_requests]

def _all_active(self, requests):
return len(requests) == len([sir for sir in requests if sir.state == 'active'])

@timeout(600)
def wait_for_instances(self, instance_ids, fail_on_terminated=True):
wait_time = 3
Expand Down