Skip to content

Fix presentation.holder instead of issuer #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ottonomy wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix presentation.holder instead of issuer #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/types/presentation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import type { Credential, Proof, Issuer } from './credential.js';

export interface VerifiablePresentation {
readonly '@context': string[];
readonly issuer: Issuer;
readonly holder: Issuer;
readonly type: string;
readonly verifiableCredential: Credential | Credential[];
readonly proof: Proof;
Expand Down
1 change: 1 addition & 0 deletions test/Verify.presentation.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,7 @@ describe('Verify.verifyPresentation', () => {
const verifiableCredential = [v2WithStatus]
const presentation = await getSignedVP({ holder, verifiableCredential }) as VerifiablePresentation
const credentialResults = [expectedV2WithStatusResult]
expect(presentation.holder).to.equal(holder)
const expectedPresentationResult = getExpectedVerifiedPresentationResult({ credentialResults })
const result = await verifyPresentation({ presentation, knownDIDRegistries })
result.credentialResults?.forEach(credResult => delete credResult.additionalInformation)
Expand Down