Skip to content

Fix vulnerabilities.#16

Open
BigBlueHat wants to merge 2 commits intomainfrom
fix-vulns
Open

Fix vulnerabilities.#16
BigBlueHat wants to merge 2 commits intomainfrom
fix-vulns

Conversation

@BigBlueHat
Copy link
Copy Markdown
Contributor

@BigBlueHat BigBlueHat commented Mar 23, 2026

  • Upgrade jsonld & http-client to latest.
  • Update engines.node.

@BigBlueHat BigBlueHat changed the title fix vulns Fix vulnerabilities. Mar 24, 2026
Copy link
Copy Markdown
Member

@davidlehn davidlehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Needs a changelog entry.
  • Easier to review if targeted at the other branch that has it's own PR.

details: {
status: e.status,
url: loc,
url: loc//,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just remove comma maybe?

Suggested change
url: loc//,
url: loc

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I do that, then I'd prefer to also remove the line below it with //...(body ? {body} : {}).

I'd prefer not to leave commented out code laying around anywhere...personally.

@BigBlueHat
Copy link
Copy Markdown
Contributor Author

  • Needs a changelog entry.

Doing these in PRs just make for merge conflicts... I'd rather we do this when making the actual release. And, as you've heard too often, GitHub has a Releases feature that's rather nice for that. 😁 However, if you really want a CHANGELOG.md file update and want to deal with the inevitable conflict...I can do that.

  • Easier to review if targeted at the other branch that has it's own PR.

Not sure what you meant here, but this is rebased on main now.

I was originally stacking the branches to get the benefit of the eslint changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants