Conversation
davidlehn
left a comment
There was a problem hiding this comment.
- Needs a changelog entry.
- Easier to review if targeted at the other branch that has it's own PR.
| details: { | ||
| status: e.status, | ||
| url: loc, | ||
| url: loc//, |
There was a problem hiding this comment.
Just remove comma maybe?
| url: loc//, | |
| url: loc |
There was a problem hiding this comment.
If I do that, then I'd prefer to also remove the line below it with //...(body ? {body} : {}).
I'd prefer not to leave commented out code laying around anywhere...personally.
Doing these in PRs just make for merge conflicts... I'd rather we do this when making the actual release. And, as you've heard too often, GitHub has a Releases feature that's rather nice for that. 😁 However, if you really want a CHANGELOG.md file update and want to deal with the inevitable conflict...I can do that.
Not sure what you meant here, but this is rebased on I was originally stacking the branches to get the benefit of the eslint changes. |
Uh oh!
There was an error while loading. Please reload this page.