Skip to content

story/HOP-47#36

Open
Girik1105 wants to merge 3 commits intodevelopfrom
story/HOP-47
Open

story/HOP-47#36
Girik1105 wants to merge 3 commits intodevelopfrom
story/HOP-47

Conversation

@Girik1105
Copy link
Copy Markdown
Contributor

@Girik1105 Girik1105 commented Apr 1, 2026

Guidelines for Pull Requests

If you haven't yet read our code review guidelines, please do so, You can find them here.

Please confirm the following by adding an x for each item (turn [ ] into [x]).

  • I have removed all code style changes that are not necessary (e.g. changing blanks across the whole file that don’t need to be changed, adding empty lines in parts other than your own code)
  • I am not making any changes to files that don’t have any effect (e.g. imports added that don’t need to be added)
  • I do not have any sysout statements in my code or commented out code that isn’t needed anymore
  • I am not reformatting any files in the wrong format or without cause.
  • I am not changing file encoding or line endings to something else than UTF-8, LF
  • My pull request does not show an insane amount of files being changed although my ticket only requires a few files being changed
  • I have added Javadoc/documentation where appropriate
  • I have added test cases where appropriate
  • I have explained any part of my code/implementation decisions that is not be self-explanatory

Please provide a brief description of your ticket

After syncing with the KB server, it needs to be possible to add or remove websites.

Description

Curators are users with the following permissions:

They should have the option to add resources that are in the KB but not tracked to Hopper, or remove websites from the KB that are not in Hopper.

HOP-47

Anything else the reviewer needs to know?

Does this Pull request depend on any other?

@diging-jenkins
Copy link
Copy Markdown

Can one of the admins verify this patch?

@jdamerow
Copy link
Copy Markdown
Member

jdamerow commented Apr 2, 2026

Make it so, Jenkins.

@jdamerow
Copy link
Copy Markdown
Member

jdamerow commented Apr 2, 2026

After I click "track resource", the resource disappears from the bottom but does not show up in the tracked resources table. I have to reload to see it.

@jdamerow jdamerow closed this Apr 2, 2026
@Girik1105 Girik1105 reopened this Apr 2, 2026
@jdamerow
Copy link
Copy Markdown
Member

jdamerow commented Apr 3, 2026

Make it so, Jenkins.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants