Skip to content

Refactor test_scale_to function - continue to establish good practices #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbillinge merged 8 commits into from
Dec 20, 2024
Merged

Refactor test_scale_to function - continue to establish good practices #255

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
91eac16
Refactor test_scale_to function
bobleesj Dec 19, 2024
e8fd9d1
Add no news
bobleesj Dec 20, 2024
890f729
Change UC to Case for unit testing
bobleesj Dec 20, 2024
49a1f7a
add INFO back to info message
sbillinge Dec 20, 2024
ba488b8
[pre-commit.ci] auto fixes from pre-commit hooks
pre-commit-ci[bot] Dec 20, 2024
fbfd3be
added high level meta-description of the group of tests in __eq__
sbillinge Dec 20, 2024
b3110bf
meta description for scale_to tests
sbillinge Dec 20, 2024
206d39d
fix info message name and change warn to print
sbillinge Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/diffpy/utils/transforms.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,7 @@
"The supplied input array and wavelength will result in an impossible two-theta. "
"Please check these values and re-instantiate the DiffractionObject with correct values."
)
inf_output_wmsg = (
"INFO: The largest output value in the array is infinite. This is allowed, but it will not be plotted."
)
inf_output_wmsg = "The largest output value in the array is infinite. This is allowed, but it will not be plotted."
Copy link
Contributor

@sbillinge sbillinge Dec 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is supposed to be an info not a warning. I think we want INFO and change wmsg to imsg in the name. Make sure it is a print and not a warning.warn in the code.

The group standard could be that a warning means that something is wrong, albeit not error generating.

Here it is "expected" that we will have infinities sometimes and we want to handle them if possible. So nothing is wrong but we want the user to alerted so they understand any magic.

Not sure if that all makes sense.



def _validate_inputs(q, wavelength):
Expand Down
Loading
Loading