Remove set_angles_from_list, set_angles_from, set_qs_from_range
#233
+23
−67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobleesj
commented
Dec 14, 2024
| def id(self, _): | ||
| raise AttributeError(_setter_wmsg("id")) | ||
|
|
||
| def set_angles_from_list(self, angles_list): |
Contributor
Author
There was a problem hiding this comment.
For the following methods, I've double checked that no tests associated were found and pytest runs locally without these.
bobleesj
commented
Dec 14, 2024
Contributor
Author
bobleesj
left a comment
bobleesj
left a comment
There was a problem hiding this comment.
@sbillinge ready for review
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #233 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 8 8
Lines 357 362 +5
=========================================
+ Hits 357 362 +5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #232