skpkg: Update rst files, copyright year in license, and autodoc_mock_import
#139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cadenmyers13
commented
Jun 13, 2025
|
|
||
| autodoc_mock_imports = [ | ||
| "diffpy.pdffit2.pdffit2", | ||
| ] |
Contributor
Author
There was a problem hiding this comment.
Added this so I could get API to render properly when i built docs.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## migration #139 +/- ##
==========================================
Coverage 98.97% 98.97%
==========================================
Files 6 6
Lines 1267 1267
==========================================
Hits 1254 1254
Misses 13 13 🚀 New features to boost your workflow:
|
Contributor
|
Very nice! Thanks for the extensive explanations |
Contributor
Author
|
@sbillinge Thanks! Sorry about the licensing mishaps 😆 I'll be more thorough moving forward 🫡 |
Contributor
Author
|
@sbillinge I'll test this if they're tutorials then this should be good to merge into main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I reverted back to the old license and just changed the copyright year to 2025 there. Please check the
conf.pyfile to see if doing the mock import for package api rendering is okay. Otherwise I could not get the package API to render locally when i built docs. The rest of the edits here are small formatting things to conform with skpkg and