Skip to content

Conversation

@bobleesj
Copy link
Contributor

@bobleesj bobleesj commented Dec 2, 2024

No description provided.

@bobleesj bobleesj marked this pull request as ready for review December 2, 2024 20:53
@github-actions
Copy link

github-actions bot commented Dec 2, 2024

Warning! No news item is found for this PR. If this is a user-facing change/feature/fix,
please add a news item by copying the format from news/TEMPLATE.rst.

@codecov
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.96%. Comparing base (183e4ed) to head (f893b50).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #104   +/-   ##
=======================================
  Coverage   98.96%   98.96%           
=======================================
  Files           6        6           
  Lines        1261     1261           
=======================================
  Hits         1248     1248           
  Misses         13       13           

Copy link
Contributor

@sbillinge sbillinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this probably needs a news

@bobleesj
Copy link
Contributor Author

bobleesj commented Dec 3, 2024

this probably needs a news

Screenshot 2024-12-03 at 5 23 51 PM

@sbillinge I've updated the existing news file as shown above.

@sbillinge sbillinge closed this Dec 3, 2024
@sbillinge sbillinge reopened this Dec 3, 2024
@sbillinge
Copy link
Contributor

sorry @bobleesj I didn't see that an old news was updated....I only looked at the failed pre-commit. This is better this way.

@sbillinge sbillinge merged commit cf12149 into diffpy:main Dec 3, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants