Skip to content

Conversation

@ycexiao
Copy link
Collaborator

@ycexiao ycexiao commented Mar 18, 2025

close #169

@ycexiao ycexiao marked this pull request as ready for review March 18, 2025 20:03
@ycexiao
Copy link
Collaborator Author

ycexiao commented Mar 18, 2025

@sbillinge It's ready for review.

I think the data should be update as soon as possible and I will open another issue to suggest a feature that can take file names as an input to extract meta data.

@codecov
Copy link

codecov bot commented Mar 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.85%. Comparing base (6526430) to head (838a53e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #171   +/-   ##
=======================================
  Coverage   96.85%   96.85%           
=======================================
  Files          18       18           
  Lines         795      795           
=======================================
  Hits          770      770           
  Misses         25       25           
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@sbillinge sbillinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see inline

@@ -0,0 +1,23 @@
**Added:**

* add temperature field to tutorial/additionalData.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be in fixed. This is not an added functionality.

@ycexiao
Copy link
Collaborator Author

ycexiao commented Mar 20, 2025

codecov will go wrong because the upstream name changed. Redo the PR.

@ycexiao ycexiao closed this Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: additional tutorial data for multiple morph misses temperature field

2 participants