-
Notifications
You must be signed in to change notification settings - Fork 3
skpkg: add cookiecutter.json, fix rendering issues in readme, add index.rst, add conftest.py, update requirements folder, update manifest.in #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@sbillinge ready for review. As I was going through the checklist for the release issue, I realized that the docs won't build, among other things. This PR serves to fix the issues I've noticed. The docs now build: Wow, I keep noticing more issues haha |
| @@ -0,0 +1,33 @@ | |||
| import argparse | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CLI utility provided by skpkg. Got this from package update
|
|
||
| [project.scripts] | ||
| diffpy-distanceprinter = "diffpy.distanceprinter:main" | ||
| diffpy-distanceprinter = "diffpy.distanceprinter.distanceprinter_app:main" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Points to the file src/diffpy/distanceprinter/distanceprinter_app.py
|
please paste the results of running pytest locally. Also please check that all the requirements files are present and up to date. T hen I can merge |
|
Here is the result of running And yes, with the addition of |
|
Let me know when this is ready for release |
|
It is in my mind to make this public too. I think it could be widely useful. Please could you look into that? We would need to give it the same treatment we gave srxconfutils |

No description provided.