Skip to content

Conversation

@dabeycorn
Copy link
Member

@dabeycorn dabeycorn commented Oct 8, 2025

There currently isn't any documentation so I just added the blank docs project.

Signed-off-by: Dasun Abeykoon <Dasun20202020@hotmail.com>
Signed-off-by: Dasun Abeykoon <Dasun20202020@hotmail.com>
Signed-off-by: Dasun Abeykoon <Dasun20202020@hotmail.com>
Signed-off-by: Dasun Abeykoon <Dasun20202020@hotmail.com>
Signed-off-by: Dasun Abeykoon <Dasun20202020@hotmail.com>
@dabeycorn dabeycorn changed the base branch from main to migration October 8, 2025 14:01
@dabeycorn
Copy link
Member Author

@zmx27 @sbillinge ready for review

Copy link
Collaborator

@zmx27 zmx27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

@sbillinge
Copy link
Contributor

Thanks @zmx27 these comments look good. Let's keep the documentation templates in case we do build docs later

Signed-off-by: Dasun Abeykoon <Dasun20202020@hotmail.com>
Signed-off-by: Dasun Abeykoon <Dasun20202020@hotmail.com>
Signed-off-by: Dasun Abeykoon <Dasun20202020@hotmail.com>
Signed-off-by: Dasun Abeykoon <Dasun20202020@hotmail.com>
Signed-off-by: Dasun Abeykoon <Dasun20202020@hotmail.com>
Signed-off-by: Dasun Abeykoon <Dasun20202020@hotmail.com>
Signed-off-by: Dasun Abeykoon <Dasun20202020@hotmail.com>
Signed-off-by: Dasun Abeykoon <Dasun20202020@hotmail.com>
@dabeycorn
Copy link
Member Author

@zmx27 ready for review

@sbillinge
Copy link
Contributor

good progress. Let's get it passing tests and we can merge.

@dabeycorn
Copy link
Member Author

sounds good, let me take a look

@sbillinge
Copy link
Contributor

btw, it doesn't require me to review to figure out it is failing tests....this is actually your responsibility....

@dabeycorn
Copy link
Member Author

btw, it doesn't require me to review to figure out it is failing tests....this is actually your responsibility....

Sorry, I knew the test were failing but I was assuming I was supposed to fix it in a separate PR considering this was a problem before migration.

@zmx27
Copy link
Collaborator

zmx27 commented Oct 15, 2025

@dabeycorn it seems like tests are failing because pre-commit is failing, so I think you can just fix that on this PR. Otherwise, I think the changes look good

Signed-off-by: Dasun Abeykoon <Dasun20202020@hotmail.com>
@dabeycorn
Copy link
Member Author

I think the pre-commit errors are coming from the migration branch, the workflows don't have proper end of files. I forgot to install pre-commit hooks before doing work there, so that's my bad.

@sbillinge
Copy link
Contributor

sounds good. Let me know when it is passing and I will merge it.

@dabeycorn
Copy link
Member Author

I don't think I can fix it in this PR because the log says it's a problem with the files in .github/workflows dir, which only exist on the migration branch not doc.

@zmx27
Copy link
Collaborator

zmx27 commented Oct 17, 2025

Please make sure to always make new branches off of the migration branch after pulling the latest changes from it

@sbillinge
Copy link
Contributor

If this branch was not built from migration then we should not merge it but do the edits over on a clean branch

@dabeycorn
Copy link
Member Author

dabeycorn commented Oct 17, 2025

Please make sure to always make new branches off of the migration branch after pulling the latest changes from it

Sorry, I started both the setup-CI and doc branches at the same time off of the same migration branch that didn't have the workflows

If this branch was not built from migration then we should not merge it but do the edits over on a clean branch

Okay, I'll redo the branch.

@dabeycorn dabeycorn closed this Oct 17, 2025
@sbillinge
Copy link
Contributor

If you started them from migration then it is ok. But maybe it is better to do this one again again. Make sure that you are running pre-commit locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants