[prone] remove failing tech.picnic.error-prone-support#2766
Merged
nedtwigg merged 1 commit intodiffplug:mainfrom Nov 22, 2025
Merged
[prone] remove failing tech.picnic.error-prone-support#2766nedtwigg merged 1 commit intodiffplug:mainfrom
tech.picnic.error-prone-support#2766nedtwigg merged 1 commit intodiffplug:mainfrom
Conversation
Pankraz76
commented
Nov 22, 2025
lib/src/diktat/java/com/diffplug/spotless/glue/diktat/DiktatFormatterFunc.java
Outdated
Show resolved
Hide resolved
CollectorMutability, fix warning StaticImportCollectorMutability, fix warning MissingOverride
b3628e2 to
bdeebe9
Compare
Pankraz76
commented
Nov 22, 2025
| } | ||
| } | ||
|
|
||
| @Override |
Author
There was a problem hiding this comment.
also rewrite, not spotless, ending up being error prone as well completing the circulation.
Line 34 in 78cc9ed
CollectorMutability, fix warning MissingOverridetech.picnic.error-prone-support
bdeebe9 to
2e88ead
Compare
3 tasks
2e88ead to
84d377e
Compare
84d377e to
d972573
Compare
Author
|
have you updated the github version somehow @nedtwigg ? Now its keeping the diff even after forbidden force push.
Now its seems ready consider suppressing all the warnings. |
- diffplug#2745 Signed-off-by: Vincent Potucek <vpotucek@me.com>
d972573 to
6356f50
Compare
Author
nedtwigg
approved these changes
Nov 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


tryout reduce warnings for:
StaticImport,NonStaticImport#2743disableAllWarnings=truegoogle/error-prone#5367Please DO NOT FORCE PUSH. Don't worry about messy history, it's easier to do code review if we can tell what happened after the review, and force pushing breaks that.
Please make sure that your PR allows edits from maintainers. Sometimes it's faster for us to just fix something than it is to describe how to fix it.
After creating the PR, please add a commit that adds a bullet-point under the
[Unreleased]section of CHANGES.md, plugin-gradle/CHANGES.md, and plugin-maven/CHANGES.md which includes:If your change only affects a build plugin, and not the lib, then you only need to update the
plugin-foo/CHANGES.mdfor that plugin.If your change affects lib in an end-user-visible way (fixing a bug, updating a version) then you need to update
CHANGES.mdfor both the lib and all build plugins. Users of a build plugin shouldn't have to refer to lib to see changes that affect them.This makes it easier for the maintainers to quickly release your changes :)