Verilog: elaboration per compilation unit#1561
Merged
Conversation
625fc67 to
191f108
Compare
IEEE 1800 2017 3.12.1 requires compliant tools to compile "compilation units" separately, with a compilation unit scope. This breaks out a function that elaborates a compilation unit by itself.
191f108 to
97d2bc0
Compare
tautschnig
approved these changes
Feb 10, 2026
| void verilog_elaborate_compilation_unit( | ||
| const verilog_parse_treet &parse_tree, | ||
| symbol_table_baset &symbol_table, | ||
| message_handlert &message_handler) |
Collaborator
There was a problem hiding this comment.
There doesn't seem to be a need for a message_handlert here?!
Collaborator
Author
There was a problem hiding this comment.
It will come -- next, this will elaborate compilation-unit scoped typedefs, functions, etc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IEEE 1800 2017 3.12.1 requires compliant tools to compile "compilation units" separately, with a compilation unit scope.
This breaks out a function that elaborates a compilation unit by itself.