Skip to content

Conversation

@remi-delmas-3000
Copy link
Collaborator

Fixes a copy and paste bug that results in a soundness bug.

The method dfcc_libraryt::ptr_pred_ctx_reset_call generated a call to the INIT function instead of the intended RESET function, which resulted in separation checks for the __CPROVER_is_fresh memory predicate failing to work across function calls between requires and ensures clauses.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig tautschnig force-pushed the remi-delmas-3000-pointer-predicate-context-reset branch from 0189646 to 5b04552 Compare December 30, 2025 21:02
… init function

Fixes a copy and paste bug that results in a soundness bug.

The method ptr_pred_ctx_reset_call generated a call to the INIT
function instead of the intended RESET function, which resulted
in separation checks for the __CPROVER_is fresh memory
predicate failing to work  across function calls between requires
and ensures clauses.
@tautschnig tautschnig force-pushed the remi-delmas-3000-pointer-predicate-context-reset branch from 5b04552 to 22b0e07 Compare December 30, 2025 21:15
@codecov
Copy link

codecov bot commented Dec 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.00%. Comparing base (e01fcdb) to head (22b0e07).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #8817   +/-   ##
========================================
  Coverage    80.00%   80.00%           
========================================
  Files         1700     1700           
  Lines       188257   188257           
  Branches        73       73           
========================================
  Hits        150615   150615           
  Misses       37642    37642           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants