Skip to content

Conversation

@DamienGilliard
Copy link
Collaborator

@DamienGilliard DamienGilliard commented Aug 7, 2025

This PR concerns the creation of a pose comparison component.
image

image

It also concerns a slight refactoring to better integrate the novelties of df2 in df1's logic: for now the integration is not as good as possible

@DamienGilliard DamienGilliard marked this pull request as draft August 7, 2025 13:59
@DamienGilliard DamienGilliard self-assigned this Aug 7, 2025
@DamienGilliard
Copy link
Collaborator Author

DamienGilliard commented Oct 20, 2025

  • pass assembly instead of i_CAD_poses. We should calculate tghe pose inside DFAssembly, in order to have the plane at the center of the beam every time
  • detect if we pass o_planes or o_history, and output one error/transformation per beam or a list of those (if we have a history and thus multiple results throughout the assembly sequence)
  • stick to planes, not pose (in the names)

@DamienGilliard
Copy link
Collaborator Author

pose comparison take i_assembly:

image

@DamienGilliard
Copy link
Collaborator Author

DamienGilliard commented Oct 30, 2025

Now works with data tree history:

image

Edit:

oupsie, no, it works but the list are messed up, and the values resulting of the component are not correct (0.25... is not correct)

Edit n°2

Now it works ;)
image

@DamienGilliard DamienGilliard changed the base branch from main to release/2.0.0 November 18, 2025 09:56
@DamienGilliard DamienGilliard marked this pull request as ready for review November 26, 2025 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants