Fixed ng lint warnings#4
Open
alundiak wants to merge 1 commit intodidinj:masterfrom
alundiak:small-changes
Open
Fixed ng lint warnings#4alundiak wants to merge 1 commit intodidinj:masterfrom alundiak:small-changes
ng lint warnings#4alundiak wants to merge 1 commit intodidinj:masterfrom
alundiak:small-changes
Conversation
- double quote vs. single quote, - BookDataSource used before declaration, - missed semicolon - unnececary semicolon - missed whitespace - let vs. const
Author
|
up :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I spotted on lint errors, when I worked with code example step by step.
Then I checked this repo, I realized the code originally not checked with
ng lint.So here I am - with small code changes, so that code syntax is correct now.
@didinj please consider this to merge, BUT, make sure u test/verify it.
And if os, also, please update ur article content on page:
https://www.djamware.com/post/5b00bb9180aca726dee1fd6d/mean-stack-angular-6-crud-web-application
Related to issue #3