fix: 修复输出RN时style block内单独@import css文件时报错问题 #2157
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiyuki
reviewed
Aug 18, 2025
| const printedParam = printParams(media, dedupe, supports, layer) | ||
| const otherParams = printedParam.length > 0 ? printedParam : '' | ||
| beforeCode += `___CSS_LOADER_EXPORT___.push([module.id, '@import "' + ${item.importName} + '";', ${JSON.stringify(otherParams)} ]);\n` | ||
| beforeCode += `___CSS_LOADER_EXPORT___.i(${item.importName}${printedParam.length > 0 ? `, ${printedParam}` : ''});\n` |
hiyuki
reviewed
Jan 23, 2026
| filter: options.import.filter, | ||
| urlHandler: (url) => { | ||
| url = combineRequests(getPreRequester(this)(options.importLoaders), url) | ||
| return getRequestString('styles', { src: url }, { |
Collaborator
There was a problem hiding this comment.
这里走原始的stringifyRequest就可以了吧
hiyuki
reviewed
Jan 23, 2026
| if (isRN) { | ||
| beforeCode += `___CSS_LOADER_EXPORT___.i(${item.importName}${hasParams ? `, ${printedParam}` : ''});\n` | ||
| } else { | ||
| const otherParams = hasParams ? printedParam : '' |
Collaborator
There was a problem hiding this comment.
你这个printedParams的处理两个分支能不能拉齐一下。。。逼死强迫症
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
修复输出RN时style block内单独@import css文件时报错问题