chore: migrate build tooling from dfx to icp-cli#236
Merged
Conversation
marc0olo
force-pushed
the
marc0olo/use-icp-cli
branch
2 times, most recently
from
5165d93 to
d432791
Compare
marc0olo
force-pushed
the
marc0olo/use-icp-cli
branch
from
d432791 to
efc4904
Compare
Contributor
|
@marc0olo in general it looks good. Some minor comments to address. |
nikosxenakis
reviewed
Mar 4, 2026
- Extract shared CI toolchain setup into composite action - Replace individual build/generate/test scripts with shell scripts (scripts/build-example.sh, scripts/test-example.sh) - Move canister configs into per-directory canister.yaml files, use glob patterns in icp.yaml - Restructure multicanister example (phonebook/superheroes into subdirectories) - Update all example READMEs with new commands, add missing icp_features entry, fix google_search title
Member
Author
|
@nikosxenakis I addressed your feedback and made following (additional) changes:
|
Rename build-example.sh → build-examples.sh and test-example.sh → test-examples.sh. Run example tests sequentially instead of in parallel to avoid resource contention on macOS CI runners.
nikosxenakis
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dfxtoicp-cli,@icp-sdk/bindgen, andmopsmo:basetomo:core@2.0.0withmoc@1.2.0superpowerstype from linked list tovec textChanges
Build system:
dfx.jsonwithicp.yaml(10 canisters: 7 Motoko, 3 Rust)mops.tomlfor Motoko toolchain and package management@icp-sdk/bindgen(icp-bindgen) for TypeScript declaration generation.didfiles for all Motoko canisters (previously auto-generated by dfx)dfinity/icp-cli-recipes@e083017(fixes gzip compression on Linux)Motoko upgrades:
mo:base/*tomo:core/*phonebook.mo:HashMap→Mapsuperheroes.mo:List.List<Text>→[Text],Trie→Mapinterfaces/modules for inter-canister calls in the multicanister exampleCI (
e2e-test-nodejs.yml):dfinity/setup-dfxwithicp-cli+ic-wasm+ic-mopsmops installto pre-cache the Motoko compiler before parallel buildsactions/cachefor Mops (toolchain + packages) and Cargo (registry + build artifacts)Cleanup:
dfx.jsonand dfx-generated actor wrappers (declarations/index.{js,d.ts})/.dfx/from.gitignore, add/.icp/cache/and/.mops/