feat(governance): Log instructions of queries in Governance.#9130
Open
daniel-wong-dfinity-org wants to merge 2 commits intomasterfrom
Open
feat(governance): Log instructions of queries in Governance.#9130daniel-wong-dfinity-org wants to merge 2 commits intomasterfrom
daniel-wong-dfinity-org wants to merge 2 commits intomasterfrom
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
daniel-wong-dfinity-org
dismissed
github-actions[bot]’s stale review
- This just adds some printlns, so I'd say that there are no "behavior" changes.
- No.
- Existing data is fine.
- Seems like very low risk.
jasonz-dfinity
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This creates a
#[query]attribute that wraps the one inic_cdk. All this new#[query]attribute does is add some logging at the end so that we can track performance.This PR was mostly written by AI.