chore: replace dfn_core type re-exports with direct ic_base_types imports#9129
Draft
jasonz-dfinity wants to merge 1 commit intomasterfrom
Draft
chore: replace dfn_core type re-exports with direct ic_base_types imports#9129jasonz-dfinity wants to merge 1 commit intomasterfrom
jasonz-dfinity wants to merge 1 commit intomasterfrom
Conversation
…orts
`dfn_core::CanisterId` and `dfn_core::api::PrincipalId` are literal
re-exports of `ic_base_types::{CanisterId, PrincipalId}`. Replace them
with direct imports to reduce unnecessary dfn_core dependencies.
For `nervous_system/canisters` and `nervous_system/common/test_utils`,
these were the only dfn_core usages, so the dfn_core dependency is
removed entirely from those crates.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dfn_core::CanisterIdanddfn_core::api::PrincipalIdre-exports with directic_base_types::imports across nervous_system and registry cratesdfn_coredependency entirely fromnervous_system/canistersandnervous_system/common/test_utils(these were their only dfn_core usages)dfn_coreliterally re-exports these types fromic_base_typesTest plan
rustfmt— no changes neededcargo clippy— passed cleanbazel build— all 10 directly affected targets passbazel test— 8 directly affected test targets pass (unit + integration)🤖 Generated with Claude Code