Skip to content

chore: Upgrade rustc to 1.93.1 #9113

Queued
michael-weigelt wants to merge 19 commits intomasterfrom
mwe/rustc
Queued

chore: Upgrade rustc to 1.93.1 #9113
michael-weigelt wants to merge 19 commits intomasterfrom
mwe/rustc

Conversation

@michael-weigelt
Copy link
Contributor

No description provided.

@michael-weigelt michael-weigelt requested review from a team as code owners March 2, 2026 12:31
@github-actions github-actions bot added the chore label Mar 2, 2026
@michael-weigelt michael-weigelt added the CI_ALL_BAZEL_TARGETS Runs all bazel targets and uploads them to S3 label Mar 2, 2026
…406a427ac8d4ab45503c341297d5c6

Image tag: b9eaadbbad56bdb2a7957bf2899858dd0734771084c023e1c4db11f9612de503
@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2026

Run URL: https://github.com/dfinity/ic/actions/runs/22755419768

New container images with tag: a72bab43cf0ba5a4de20cacc82247b38c64a779ace23157d0aa200d3af7c41d1
ic-build: sha256:0a0cff0b12c7586c2f312c739176924edf0c9e71df92f382eba836913da9f1c6
ic-dev: sha256:a98782800df599b3d1501f0da9fbe1dff7a8a401a86c0371eaab7ae0503d3696

@basvandijk
Copy link
Collaborator

I'm surprised you didn't need to upgrade rules_rust for this. But I guess if it works it works.

michael-weigelt and others added 2 commits March 2, 2026 13:53
…d4b18bb2864c8452a93d2e6855ed58

Image tag: b9eaadbbad56bdb2a7957bf2899858dd0734771084c023e1c4db11f9612de503
Copy link
Member

@venkkatesh-sekar venkkatesh-sekar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be the smallest toolchain upgrade PR!!

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request changes code owned by the Governance team. Therefore, make sure that
you have considered the following (for Governance-owned code):

  1. Update unreleased_changelog.md (if there are behavior changes, even if they are
    non-breaking).

  2. Are there BREAKING changes?

  3. Is a data migration needed?

  4. Security review?

How to Satisfy This Automatic Review

  1. Go to the bottom of the pull request page.

  2. Look for where it says this bot is requesting changes.

  3. Click the three dots to the right.

  4. Select "Dismiss review".

  5. In the text entry box, respond to each of the numbered items in the previous
    section, declare one of the following:

  • Done.

  • $REASON_WHY_NO_NEED. E.g. for unreleased_changelog.md, "No
    canister behavior changes.", or for item 2, "Existing APIs
    behave as before.".

Brief Guide to "Externally Visible" Changes

"Externally visible behavior change" is very often due to some NEW canister API.

Changes to EXISTING APIs are more likely to be "breaking".

If these changes are breaking, make sure that clients know how to migrate, how to
maintain their continuity of operations.

If your changes are behind a feature flag, then, do NOT add entrie(s) to
unreleased_changelog.md in this PR! But rather, add entrie(s) later, in the PR
that enables these changes in production.

Reference(s)

For a more comprehensive checklist, see here.

GOVERNANCE_CHECKLIST_REMINDER_DEDUP

Copy link
Contributor

@jasonz-dfinity jasonz-dfinity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for rs/registry and rs/nervous_system

Copy link
Contributor

@kpop-dfinity kpop-dfinity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Also, wanted to point out that the PR number (9113) is an anagram of the version you're updating rust to (1.93.1), good timing :P

@michael-weigelt michael-weigelt dismissed github-actions[bot]’s stale review March 3, 2026 10:08

this is a version upgrade with no semantic changes

mraszyk and others added 2 commits March 6, 2026 09:28
…a779ace23157d0aa200d3af7c41d1

ic-build: sha256:0a0cff0b12c7586c2f312c739176924edf0c9e71df92f382eba836913da9f1c6

ic-dev:   sha256:a98782800df599b3d1501f0da9fbe1dff7a8a401a86c0371eaab7ae0503d3696
@michael-weigelt michael-weigelt added this pull request to the merge queue Mar 6, 2026
Any commits made after this event will not be merged.
@michael-weigelt
Copy link
Contributor Author

Seems like the build determinism issues are gone in this version, @nmattia

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants