Conversation
…406a427ac8d4ab45503c341297d5c6 Image tag: b9eaadbbad56bdb2a7957bf2899858dd0734771084c023e1c4db11f9612de503
|
Run URL: https://github.com/dfinity/ic/actions/runs/22755419768 New container images with tag: |
|
I'm surprised you didn't need to upgrade rules_rust for this. But I guess if it works it works. |
…d4b18bb2864c8452a93d2e6855ed58 Image tag: b9eaadbbad56bdb2a7957bf2899858dd0734771084c023e1c4db11f9612de503
venkkatesh-sekar
left a comment
There was a problem hiding this comment.
This might be the smallest toolchain upgrade PR!!
There was a problem hiding this comment.
This pull request changes code owned by the Governance team. Therefore, make sure that
you have considered the following (for Governance-owned code):
-
Update
unreleased_changelog.md(if there are behavior changes, even if they are
non-breaking). -
Are there BREAKING changes?
-
Is a data migration needed?
-
Security review?
How to Satisfy This Automatic Review
-
Go to the bottom of the pull request page.
-
Look for where it says this bot is requesting changes.
-
Click the three dots to the right.
-
Select "Dismiss review".
-
In the text entry box, respond to each of the numbered items in the previous
section, declare one of the following:
-
Done.
-
$REASON_WHY_NO_NEED. E.g. for
unreleased_changelog.md, "No
canister behavior changes.", or for item 2, "Existing APIs
behave as before.".
Brief Guide to "Externally Visible" Changes
"Externally visible behavior change" is very often due to some NEW canister API.
Changes to EXISTING APIs are more likely to be "breaking".
If these changes are breaking, make sure that clients know how to migrate, how to
maintain their continuity of operations.
If your changes are behind a feature flag, then, do NOT add entrie(s) to
unreleased_changelog.md in this PR! But rather, add entrie(s) later, in the PR
that enables these changes in production.
Reference(s)
For a more comprehensive checklist, see here.
GOVERNANCE_CHECKLIST_REMINDER_DEDUP
jasonz-dfinity
left a comment
There was a problem hiding this comment.
LGTM for rs/registry and rs/nervous_system
kpop-dfinity
left a comment
There was a problem hiding this comment.
LGTM
Also, wanted to point out that the PR number (9113) is an anagram of the version you're updating rust to (1.93.1), good timing :P
this is a version upgrade with no semantic changes
…a779ace23157d0aa200d3af7c41d1 ic-build: sha256:0a0cff0b12c7586c2f312c739176924edf0c9e71df92f382eba836913da9f1c6 ic-dev: sha256:a98782800df599b3d1501f0da9fbe1dff7a8a401a86c0371eaab7ae0503d3696
|
Seems like the build determinism issues are gone in this version, @nmattia |
No description provided.