Skip to content

feat(IDX): use tags instead of image id#9110

Closed
cgundy wants to merge 10 commits intomasterfrom
use-tags-instead-of-image-id
Closed

feat(IDX): use tags instead of image id#9110
cgundy wants to merge 10 commits intomasterfrom
use-tags-instead-of-image-id

Conversation

@cgundy
Copy link
Contributor

@cgundy cgundy commented Mar 2, 2026

Since splitting out into two images ic-dev and ic-build the logic has become quite a bit more complex. Although we use the same tags for both images, they have different image ids:

For this reason, it's easier to update our CI to use image tags instead of image ids when referencing the images.

Image tag: 0b026f2d222333c8f0b7a8c3f4b426a15e94611512f143577538913e62349d6f
@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2026

Run URL: https://github.com/dfinity/ic/actions/runs/22576409609

New container tag: 7901a473a840d3dcddd8f5b21fd34c9131c75e9f56e3c5617ec579584ceb4b64

@cgundy cgundy marked this pull request as ready for review March 2, 2026 13:01
@cgundy cgundy requested review from a team as code owners March 2, 2026 13:01
Copy link
Collaborator

@basvandijk basvandijk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thanks. I'll close #9094.

@cgundy cgundy enabled auto-merge March 2, 2026 13:08
IMG_NAME_FULL="ghcr.io/${IMG_NAME}@${{ needs.ic-build-image.outputs.imageid }}"
IMAGE_PREFIX="ghcr.io/dfinity/"
IMG_NAME_IC_BUILD="${IMAGE_PREFIX}ic-build:${{ needs.build-image-prep.outputs.image_tag }}"
IMG_NAME_IC_DEV="${IMAGE_PREFIX}ic-dev:${{ needs.build-image-prep.outputs.image_tag }}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

out of curiosity, is there a reason we use a tag additionally to the image id? both are a hashed representation of the inputs, though the image ID is guaranteed to be correct, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding is that the image tag is for CI logic - so that we know when to re-trigger a container build. Otherwise we'd need to query the registry.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Carly and I also had a chat about whether to go for tags or image IDs. One advantage of image IDs is that it's completely unambiguous which image you're using whereas referencing an image via tag could result in a different image if the image was later rebuild and reuploaded.

@cgundy cgundy marked this pull request as draft March 2, 2026 14:29
auto-merge was automatically disabled March 2, 2026 14:29

Pull request was converted to draft

@cgundy cgundy closed this Mar 3, 2026
@fspreiss
Copy link
Contributor

fspreiss commented Mar 3, 2026

@cgundy, you closed the PR: is there an alternative PR achieving the same thing: I'm basically waiting for the gh command to be available in the devcontainer in VSCode/Cursor (because my AI agent wants to use it).

@cgundy
Copy link
Contributor Author

cgundy commented Mar 3, 2026

@fspreiss yes, I closed it in favor of this one: #9099

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants