Conversation
Image tag: 0b026f2d222333c8f0b7a8c3f4b426a15e94611512f143577538913e62349d6f
|
Run URL: https://github.com/dfinity/ic/actions/runs/22576409609 New container tag: |
This reverts commit bfd832c.
…e9f56e3c5617ec579584ceb4b64
basvandijk
left a comment
There was a problem hiding this comment.
Nice. Thanks. I'll close #9094.
| IMG_NAME_FULL="ghcr.io/${IMG_NAME}@${{ needs.ic-build-image.outputs.imageid }}" | ||
| IMAGE_PREFIX="ghcr.io/dfinity/" | ||
| IMG_NAME_IC_BUILD="${IMAGE_PREFIX}ic-build:${{ needs.build-image-prep.outputs.image_tag }}" | ||
| IMG_NAME_IC_DEV="${IMAGE_PREFIX}ic-dev:${{ needs.build-image-prep.outputs.image_tag }}" |
There was a problem hiding this comment.
out of curiosity, is there a reason we use a tag additionally to the image id? both are a hashed representation of the inputs, though the image ID is guaranteed to be correct, right?
There was a problem hiding this comment.
My understanding is that the image tag is for CI logic - so that we know when to re-trigger a container build. Otherwise we'd need to query the registry.
There was a problem hiding this comment.
Carly and I also had a chat about whether to go for tags or image IDs. One advantage of image IDs is that it's completely unambiguous which image you're using whereas referencing an image via tag could result in a different image if the image was later rebuild and reuploaded.
Pull request was converted to draft
|
@cgundy, you closed the PR: is there an alternative PR achieving the same thing: I'm basically waiting for the |
Since splitting out into two images
ic-devandic-buildthe logic has become quite a bit more complex. Although we use the same tags for both images, they have different image ids:For this reason, it's easier to update our CI to use image tags instead of image ids when referencing the images.