Skip to content

feat: [IC-1992] interface changes for the new NNS proposal type: SplitSubnet#9100

Merged
kpop-dfinity merged 14 commits intomasterfrom
kpop/feat_nns_interface_changes
Mar 13, 2026
Merged

feat: [IC-1992] interface changes for the new NNS proposal type: SplitSubnet#9100
kpop-dfinity merged 14 commits intomasterfrom
kpop/feat_nns_interface_changes

Conversation

@kpop-dfinity
Copy link
Copy Markdown
Contributor

@kpop-dfinity kpop-dfinity commented Mar 2, 2026

What's changed:

  1. Introduced a new NNS function SplitSubnet - currently it will be disabled
  2. Added cup_type to the CatchUpPackage protobuf with a new variant SubnetSplitting which will eventually instruct a subnet to be split

Notes

The implementation of the do_split_subnet registry canister endpoint is done in a follow-up PR #8692

@github-actions github-actions Bot added the feat label Mar 2, 2026
@kpop-dfinity kpop-dfinity changed the title feat: nns interfance changes feat: preparation for the Subnet Splitting proposal Mar 3, 2026
@kpop-dfinity kpop-dfinity changed the title feat: preparation for the Subnet Splitting proposal feat: [IC-1992] preparation for the Subnet Splitting proposal Mar 3, 2026
@kpop-dfinity kpop-dfinity changed the title feat: [IC-1992] preparation for the Subnet Splitting proposal feat: [IC-1992] interface changes for the new NNS proposal type: SplitSubnet Mar 3, 2026
@kpop-dfinity kpop-dfinity marked this pull request as ready for review March 3, 2026 13:46
@kpop-dfinity kpop-dfinity requested review from a team as code owners March 3, 2026 13:46
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request changes code owned by the Governance team. Therefore, make sure that
you have considered the following (for Governance-owned code):

  1. Update unreleased_changelog.md (if there are behavior changes, even if they are
    non-breaking).

  2. Are there BREAKING changes?

  3. Is a data migration needed?

  4. Security review?

How to Satisfy This Automatic Review

  1. Go to the bottom of the pull request page.

  2. Look for where it says this bot is requesting changes.

  3. Click the three dots to the right.

  4. Select "Dismiss review".

  5. In the text entry box, respond to each of the numbered items in the previous
    section, declare one of the following:

  • Done.

  • $REASON_WHY_NO_NEED. E.g. for unreleased_changelog.md, "No
    canister behavior changes.", or for item 2, "Existing APIs
    behave as before.".

Brief Guide to "Externally Visible" Changes

"Externally visible behavior change" is very often due to some NEW canister API.

Changes to EXISTING APIs are more likely to be "breaking".

If these changes are breaking, make sure that clients know how to migrate, how to
maintain their continuity of operations.

If your changes are behind a feature flag, then, do NOT add entrie(s) to
unreleased_changelog.md in this PR! But rather, add entrie(s) later, in the PR
that enables these changes in production.

Reference(s)

For a more comprehensive checklist, see here.

GOVERNANCE_CHECKLIST_REMINDER_DEDUP

Comment thread rs/consensus/cup_utils/src/lib.rs
Comment thread rs/registry/canister/src/mutations/do_create_subnet.rs Outdated
Comment thread rs/protobuf/def/registry/subnet/v1/subnet.proto Outdated
Comment thread rs/protobuf/def/registry/subnet/v1/subnet.proto
Comment thread rs/nns/governance/src/proposals/execute_nns_function.rs Outdated
Comment thread rs/registry/canister/src/mutations/routing_table.rs Outdated
Comment thread rs/registry/routing_table/src/lib.rs Outdated
Comment thread rs/registry/canister/src/mutations/do_create_subnet.rs Outdated
@kpop-dfinity kpop-dfinity requested a review from a team as a code owner March 5, 2026 18:14
@github-actions github-actions Bot added the @idx label Mar 5, 2026
@kpop-dfinity kpop-dfinity dismissed github-actions[bot]’s stale review March 10, 2026 13:03
  1. Update unreleased_changelog.md (if there are behavior changes, even if they are non-breaking) - Done

  2. Are there BREAKING changes? - No

  3. Is a data migration needed? - No

  4. Security review? - prod-sec team has reviewed the design

@kpop-dfinity kpop-dfinity added this pull request to the merge queue Mar 13, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Mar 13, 2026
@kpop-dfinity kpop-dfinity added this pull request to the merge queue Mar 13, 2026
Merged via the queue into master with commit 3bc8b12 Mar 13, 2026
39 checks passed
@kpop-dfinity kpop-dfinity deleted the kpop/feat_nns_interface_changes branch March 13, 2026 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants