chore: Drop ic_types::Funds
#8334
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All protos with an `ic_protobuf::...::Funds` field (e.g. `Request` and `Response`) already have an equivalent `ic_protobuf::Cycles` field; always populate both; and can be populated from either. `CallContext` only has a `Funds` field, meaning that we can't get rid of `ic_types::Funds` (and the equivalent proro) just yet. Add an `ic_protobuf::CallContext::available_cycles` field, so that we can get rid of `available_funds` (and the `Funds` types) in the following replica release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The struct was deprecated a long time ago (it's a combination of ICP and cycles; but transferring ICP via canister calls was never implemented; so it was eventually replaced by
Cyclesfields in most places).Following recent changes that added (and populated and persisted) a
Cyclesfield next to everyFundsfield, it is now safe to drop the type from the Replicated State and from checkpoints. (Dropping it from the canonical state is independent and also going on in parallel.)