-
Notifications
You must be signed in to change notification settings - Fork 372
feat(nns): Post-process potentially large fields in NnsCanisterInstall/HardResetRootToVersion SelfDescribingValue #8323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request changes code owned by the Governance team. Therefore, make sure that
you have considered the following (for Governance-owned code):
-
Update
unreleased_changelog.md(if there are behavior changes, even if they are
non-breaking). -
Are there BREAKING changes?
-
Is a data migration needed?
-
Security review?
How to Satisfy This Automatic Review
-
Go to the bottom of the pull request page.
-
Look for where it says this bot is requesting changes.
-
Click the three dots to the right.
-
Select "Dismiss review".
-
In the text entry box, respond to each of the numbered items in the previous
section, declare one of the following:
-
Done.
-
$REASON_WHY_NO_NEED. E.g. for
unreleased_changelog.md, "No
canister behavior changes.", or for item 2, "Existing APIs
behave as before.".
Brief Guide to "Externally Visible" Changes
"Externally visible behavior change" is very often due to some NEW canister API.
Changes to EXISTING APIs are more likely to be "breaking".
If these changes are breaking, make sure that clients know how to migrate, how to
maintain their continuity of operations.
If your changes are behind a feature flag, then, do NOT add entrie(s) to
unreleased_changelog.md in this PR! But rather, add entrie(s) later, in the PR
that enables these changes in production.
Reference(s)
For a more comprehensive checklist, see here.
GOVERNANCE_CHECKLIST_REMINDER_DEDUP
f0a2029 to
1c3cdfb
Compare
0cc36c6 to
842eda0
Compare
842eda0 to
20c0b80
Compare
fdcd1c2 to
82c0b82
Compare
460e0bc to
20ed12a
Compare
82c0b82 to
74a5d33
Compare
20ed12a to
4dcf514
Compare
52f6571 to
7984a9c
Compare
74a5d33 to
f48bafd
Compare
7984a9c to
21394b4
Compare
N/A behind feature flag
…RootToVersion by hashing them
6aa8a0f to
9c1f2c4
Compare
Post-process potentially large fields in NnsCanisterInstall/HardResetRootToVersion SelfDescribingValue. Note that this treatment is highly consistent with
InstallCode- only the hashes are returned, with the field names as*_hashinstead of*.