Skip to content

Fixes: "Mipmap not found in texture" exception for textures with a height that isn't a multiple of 4 but is compressed. #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hickorysb wants to merge 3 commits into from
Closed

Fixes: "Mipmap not found in texture" exception for textures with a height that isn't a multiple of 4 but is compressed. #321

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
27de223
Fixes "Mipmap not found in texture" exception for textures with a hei…
hickorysb Apr 6, 2025
bbd0998
Remove extra logging that was left in from initially debugging the is…
hickorysb Apr 6, 2025
c26824b
Change Math.Max(1 to Math.Max(4 as minimum dimension should be 4 not 1.
hickorysb Apr 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CodeWalker.Core/GameFiles/Resources/Texture.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -707,6 +707,7 @@ public int CalcDataSize()
len += slicePitch;
div *= 2;
}

return len * Depth;
}
public ushort CalculateStride()
Expand Down Expand Up @@ -1099,6 +1100,13 @@ public override void Read(ResourceDataReader reader, params object[] parameters)
int Levels = Convert.ToInt32(parameters[3]);
int Stride = Convert.ToInt32(parameters[4]);

bool compressed = DDSIO.DXTex.IsCompressed(DDSIO.GetDXGIFormat((TextureFormat)format));

if (compressed && Height % 4 != 0)
{
Height = Math.Max(4, (Height + 3) & ~3);
}

int fullLength = 0;
int length = Stride * Height;
for (int i = 0; i < Levels; i++)
Expand Down