Skip to content

fix: clusterId check for modifying triggers for cluster level notific…#6932

Merged
SATYAsasini merged 1 commit intomainfrom
fix-cluster-level-notification-trigger-update
Mar 11, 2026
Merged

fix: clusterId check for modifying triggers for cluster level notific…#6932
SATYAsasini merged 1 commit intomainfrom
fix-cluster-level-notification-trigger-update

Conversation

@SATYAsasini
Copy link
Contributor

@SATYAsasini SATYAsasini commented Mar 11, 2026

…ation

Description

Fixes https://github.com/devtron-labs/sprint-tasks/issues/2849

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


Summary by Bito

  • Updated the SQL query in FetchNotificationSettingGroupBy to select cluster_id and adjusted the group by clause to include it.
  • Added assignment of ClusterId to notificationSettingsRequest in the updateNotificationSetting function.

@github-actions
Copy link

Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n

@github-actions
Copy link

Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n

@sonarqubecloud
Copy link

@SATYAsasini SATYAsasini merged commit e1cfcd6 into main Mar 11, 2026
12 of 14 checks passed
@SATYAsasini SATYAsasini deleted the fix-cluster-level-notification-trigger-update branch March 11, 2026 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants