Open
Conversation
Added AssumeRoleArn field across all services that interact with ECR: common-lib: - helmLib/registry: Configuration bean + extractCredentialsForRegistry - utils/bean: DockerAuthConfig.AssumeRoleArnEcr - utils/dockerOperations: LoadEcrCredentials with AssumeRole kubelink: - gRPC proto: AssumeRoleArn field (tag 15) on RegistryCredential - adapter: pass AssumeRoleArn to registry Configuration ci-runner: - DockerCredentials struct + DockerLogin: STS AssumeRole before ECR auth - CommonWorkflowRequest: AssumeRoleArn field - GetDockerAuthConfigForPrivateRegistries: pass ARN - Added log lines for cross-account login confirmation image-scanner: - DockerArtifactStore model: AssumeRoleArn field - RoundTripperService: STS AssumeRole in GetAuthenticatorByDockerRegistryId
The DockerCredentials literal in StartDockerDaemonAndDockerLogin was missing AssumeRoleArn, causing ec2rolecreds fallback failure in pods. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Ash-exp
requested review from
prakarsh-dt,
vikramdevtron and
vivek-devtron
as code owners
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n |
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n |
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n |
Ash-exp
changed the title
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n |
vikramdevtron
approved these changes
Apr 7, 2026
github-actions
bot
added
PR:Ready-to-Review
and removed
PR:Issue-verification-failed
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/devtron-labs/sprint-tasks/issues/2868