Conversation
deepak-devtron
requested review from
prakarsh-dt,
vikramdevtron and
vivek-devtron
as code owners
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n |
- Move DockerfileScanRequest and ScanConfig to dedicated bean file - Remove polling logic from InitiateDockerfileScan (fail-fast) - Handle filepath.Abs error and improve error logging - Add panic recovery to asynchronous scan goroutine - Remove unused IgnoredRules field and cleanup code
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n |
- CI-Runner now blindly trusts Orchestrator's decision - Removed: DockerfileScanEnabled OR ForceDockerfileScan check - Now uses: DockerfileScanEnabled only (Orchestrator computes OR logic) - Orchestrator passes pre-computed shouldScan in DockerfileScanEnabled field - This ensures single source of truth for scan decision Architecture: - Orchestrator: Decides (userEnabled OR orgForced) - CI-Runner: Executes blindly (no decision logic) - Image-Scanner: Executes blindly (no decision logic) Part of Phase 1: Simplified Dockerfile scan architecture Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n |
…tManager build error - Added tests for Success, MissingFile, and ServerError scenarios in DockerfileScanHelper - Fixed pre-existing compilation error in GitManager_test.go (CloneAndCheckout signature mismatch) - Tests verify scan request payload, error handling, and graceful degradation Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n |
- Remove duplicate endpoint definition by reusing PubSubConfig - Remove unnecessary flags (DockerfileScanEnabled/ForceDockerfileScan) from request payload - Reduce log noise by removing redundant error handling in non-critical path Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n |
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n |
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n |
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n |
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n |
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n |
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n |
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n |
github-actions
bot
added
PR:Ready-to-Review
and removed
PR:Issue-verification-failed
labels
5 participants
Fixes: https://github.com/devtron-labs/sprint-tasks/issues/2829