Make navbar sticky under header when scroll. Add useElementHeight Hook#10
Open
Linn-Devoteam wants to merge 1 commit intomainfrom
Open
Make navbar sticky under header when scroll. Add useElementHeight Hook#10Linn-Devoteam wants to merge 1 commit intomainfrom
Linn-Devoteam wants to merge 1 commit intomainfrom
Conversation
…k to get Header height
Collaborator
|
Very nice idea :) An issue though, when the page is too long and start scrolling beyond the "Components" section, the nav is pushed up while the tabs are sticky |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
This PR makes the navbar sticky under the header when scrolling. It adds useElementHeight to get the header height dynamically, making the behavior stable and responsive.
How to test
Install and start the project:
npm installnpm run devOpen local host
Type of Change
feature: New featurechore: Maintenance, dependency updates, or refactoringtest: Adding or improving testsbug: Bug fixdocs: Documentation updatesShortcut story
https://trello.com/c/d4b6xYI6/22-bug-text-shown-under-header-when-scrolling-on-page
Related Issues
Testing Performed
Screenshots/Recordings
Checklist
Additional Notes