Refactor configuration-driven client factory resolution#271
Merged
Conversation
kzu
force-pushed
the
dev/refactor-client-factory-resolution
branch
from
8571185 to
a0ebd03
Compare
Bind client factories to configuration sections and resolve them through
IClientFactoryResolver and ClientFactoryResolver so configurable clients and
DI registrations are driven by section paths and service keys.
Validation:
- dotnet build Extensions.AI.slnx
- dotnet format whitespace -v:diag --exclude ~/.nuget
- dotnet format style -v:diag --exclude ~/.nuget
- dotnet test src\Tests\Tests.csproj --no-build --filter "FullyQualifiedName~ConfigurableClientTests"
- dotnet test src\Tests\Tests.csproj --no-build --filter "FullyQualifiedName!~Devlooped.EndToEnd"
Known issue:
- dnx --yes retest and the full test project currently fail because
Devlooped.EndToEnd.GetText in src/Tests/EndToEnd.cs asserts
GetChatClient("XAI") is not null for a config shape that does not register
that chat client id.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
kzu
force-pushed
the
dev/refactor-client-factory-resolution
branch
from
a0ebd03 to
59f2a00
Compare
Member
Author
|
🧪 Details on Ubuntu 24.04.4 LTSfrom retest v1.1.0 on .NET 10.0.7 with 💜 by @devlooped |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor configuration-driven client factory resolution
Bind client factories to configuration sections and resolve them through
IClientFactoryResolver and ClientFactoryResolver so configurable clients and
DI registrations are driven by section paths and service keys.
Validation:
Known issue:
Devlooped.EndToEnd.GetText in src/Tests/EndToEnd.cs asserts
GetChatClient("XAI") is not null for a config shape that does not register
that chat client id.