Add metadata to fifo pipe output by iVolt1 · Pull Request #203 · devgianlu/go-librespot

iVolt1 · 2025-09-07T15:19:28Z

Add metadata to fifo pipe output as requested in: Add metadata output to a pipe as it is in librespot-java #157

Functionally this works very well showing track info, duration and timing, and artwork when piped into owntone and the Home Assistant dashboard when running when running in an addon.

I used AI to help write it and don't see any issues at this point. This is my first pull request so I expect there will be nits and other issues, but I will do will what I can to help push this forward.

iVolt1 · 2025-09-07T16:01:34Z

This is the config.yml I have been using:

zeroconf_enabled: true # Whether to keep the device discoverable at all times, even if authenticated via other means
zeroconf_port: 0 # The port to use for Zeroconf, 0 for random
credentials:
  type: zeroconf
  zeroconf:
    persist_credentials: true # Whether to persist zeroconf user credentials even after disconnecting
server:
  enabled: true
  address: '0.0.0.0' #localhost # Which address to bind to
  port: 3678 #24879 #3678 # The server port
  allow_origin: '192.168.1.123' # Value for the Access-Control-Allow-Origin header
  cert_file: '' # Path to certificate file for TLS
  key_file: '' # Path to key file for TLS  
log_level: info # Log level configuration (trace, debug, info, warn, error)
device_id: '' # Spotify device ID (auto-generated)
device_name: 'Spotify Go' # Spotify device name
device_type: computer # Spotify device type (icon)
audio_backend: pipe # alsa # Audio backend to use (alsa, pipe, pulseaudio)
audio_output_pipe: '/media/music/librespot-java' # Path to a named pipe for audio output
audio_output_pipe_format: s16le # Audio output pipe format (s16le, s32le, f32le)
audio_buffer_time: 100
bitrate: 320 # Playback bitrate (96, 160, 320)
volume_steps: 100 # Volume steps count
initial_volume: 100 # Initial volume in steps (not applied to the mixer device)
external_volume: true # Whether volume is controlled externally 
disable_autoplay: false # Whether autoplay of more songs should be disabled
metadata_pipe:
  enabled: true
  path: '/media/music/librespot-java.metadata' # Audio pipe + .metadata
  format: "xml"
  buffer_size: 100

devgianlu

First review, I did not test it and generally glazed over some things.

Thank you for your effort!

devgianlu · 2025-09-10T17:26:55Z

cmd/daemon/controls.go

 	"google.golang.org/protobuf/proto"
 )

+// Update extractMetadataFromStream method signature:


Tautological comment

devgianlu · 2025-09-10T17:27:22Z

cmd/daemon/controls.go

+		}
+	}
+
+	return title, artist, album, trackID, duration, artworkURL, artworkData


We should not be returning that many values

devgianlu · 2025-09-10T17:27:32Z

cmd/daemon/controls.go

+		/*
+			if p.primaryStream != nil {
+				title, artist, album, trackID, duration, artworkURL := p.extractMetadataFromStream(p.primaryStream)
+				p.app.log.Debugf("Sending metadata: %s by %s", title, artist)
+				p.UpdateTrack(title, artist, album, trackID, duration, true, artworkURL) // true = playing
+			}
+		*/


Can this be definitely removed?

devgianlu · 2025-09-10T17:27:44Z

cmd/daemon/controls.go


+		p.UpdatePlayingState(true)
+
+		// Add this line to update position on resume


Tautological comment

devgianlu · 2025-09-10T17:28:04Z

cmd/daemon/controls.go


 	p.sess.Events().PostPrimaryStreamLoad(p.primaryStream, paused)

+	// In loadCurrentTrack method:


Tautological comment

devgianlu · 2025-09-10T17:35:14Z

player/player.go

 	drop    bool
 }

+// Update MetadataCallback interface:


Tautological comment

devgianlu · 2025-09-10T17:35:49Z

.gitignore

+/daemon
+/go-librespot


I guess these are because you are cross-compiling, but they are a bit misleading

devgianlu · 2025-09-10T17:37:39Z

metadata/fifo.go

+
+	_, err := fm.pipe.Write(data)
+	if err != nil {
+		// Close and attempt to reopen on error


Doesn't seem reconnection happens on error

devgianlu · 2025-09-10T17:38:24Z

metadata/fifo.go

+	switch fm.format {
+	//	case "json":
+	//		data = metadata.ToJSONFormat()
+	case "xml": // ADD THIS CASE
+		data = metadata.ToXMLFormat()
+		//default: // "dacp"
+		//	data = metadata.ToDACPFormat()
+	}


These should be supported right?

devgianlu · 2025-09-10T17:39:25Z

metadata/player_wrapper.go

+}
+
+// Update UpdateTrack method signature:
+func (pm *PlayerMetadata) UpdateTrack(title, artist, album, trackID string, duration time.Duration, playing bool, artworkURL string, artworkData []byte) {


Perhaps we can use a struct here

- Remove tautological comments throughout codebase - Refactor UpdateTrack to use TrackUpdateInfo struct instead of 8 parameters - Refactor extractMetadataFromStream to return struct instead of 7 values - Support all metadata format cases (JSON, XML, DACP) in FIFO manager - Fix misleading reconnection comment - Clean up merge conflicts and duplicate function definitions

- Add variable declarations in extractMetadataFromStream - Update AppPlayer.UpdateTrack to accept TrackUpdateInfo struct - Remove duplicate timer initialization in main.go - Change FIFO startup error to warning - Handle EEXIST gracefully in FIFO creation - Add binaries to .gitignore

iVolt1 · 2025-11-21T23:52:10Z

Hi @devgianlu,

I've addressed all the review feedback:

✅ Removed tautological comments throughout the codebase
✅ Refactored UpdateTrack to use TrackUpdateInfo struct instead of 8 parameters
✅ Refactored extractMetadataFromStream to return struct instead of 7 return values
✅ Implemented all format cases (JSON, XML, DACP) in FIFO manager
✅ Fixed misleading reconnection comment
✅ Cleaned up commented code and merge conflicts

The code now compiles successfully and I've tested it in my Home Assistant addon with OwnTone - metadata (including track info, artwork, and position updates) is flowing correctly.

Let me know if there's anything else you'd like me to change!

iVolt1 and others added 11 commits August 24, 2025 12:45

Add metadata piping and daemon control enhancements

32cc168

Add metadata piping and daemon control enhancements

2cb7127

Add metadata piping and daemon control enhancements

f12d7b4

Add metadata piping and daemon control enhancements

96b4688

Add metadata piping and daemon control enhancements

49d2f04

Add metadata piping and daemon control enhancements

ff25da7

Merge branch 'devgianlu:master' into metadata-pipe

3ec9a15

pipe metadata and play/next fix

d44c298

Merge branch 'devgianlu:master' into metadata-pipe

ea02188

Merge branch 'devgianlu:master' into metadata-pipe

3c7e5df

Remove binary executables

1275a6e

devgianlu requested changes Sep 10, 2025

View reviewed changes

devgianlu linked an issue Sep 10, 2025 that may be closed by this pull request

Add metadata output to a pipe as it is in librespot-java #157

Open

devgianlu mentioned this pull request Sep 29, 2025

Outdated librespot makes calls to Spotify fail with a 500 error spocon/spocon#68

Open

Merge remote-tracking branch 'upstream/master' into metadata-pipe

f4c58a3

iVolt1 force-pushed the metadata-pipe branch from 4079b8f to f4c58a3 Compare November 21, 2025 16:25

iVolt1 added 2 commits November 21, 2025 13:27

Remove debug printf statements from metadata

0416de7


		p.UpdatePlayingState(true)

		// Add this line to update position on resume


		p.sess.Events().PostPrimaryStreamLoad(p.primaryStream, paused)

		// In loadCurrentTrack method:

		/daemon
		/go-librespot

Conversation

iVolt1 commented Sep 7, 2025

Uh oh!

iVolt1 commented Sep 7, 2025 • edited by devgianlu Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

devgianlu left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

iVolt1 commented Nov 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

iVolt1 commented Sep 7, 2025 •

edited by devgianlu

Loading