chore: Add new go stack version with the new runtime image version#665
chore: Add new go stack version with the new runtime image version#665vinokurig wants to merge 4 commits intodevfile:mainfrom
Conversation
Signed-off-by: Ihor Vinokur <ivinokur@redhat.com>
|
Hi @vinokurig. Thanks for your PR. I'm waiting for a devfile member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
michael-valdron
left a comment
michael-valdron
left a comment
There was a problem hiding this comment.
@vinokurig I'm guessing from the description that the updates here are to provide a stack version that provides Go 1.25, correct?
Provided feedback based on that assumption.
| checkoutFrom: | ||
| revision: v2.5.0 | ||
| remotes: | ||
| origin: https://github.com/devfile-samples/devfile-stack-go.git |
There was a problem hiding this comment.
We'll also want an update to the starter project to have Go 1.25 and a stack version reference tag with these changes.
There was a problem hiding this comment.
There was a problem hiding this comment.
@michael-valdron We would need to push a new tag after the pull request. Would you be able to do that?
stacks/go/stack.yaml
Outdated
| # 2.5.0: debug command via dlv & go 1.24 | ||
| - version: 2.5.0 | ||
| # 2.5.1: updated runtime image version | ||
| - version: 2.5.1 |
There was a problem hiding this comment.
We should do a minor version bump since the Go version is changing:
| - version: 2.5.1 | |
| - version: 2.6.0 |
Also, can we make the same cut for 1.x stack versions, 1.5.0 version that does the bump in Go runtime. We have this to keep compatibility with Devfile 2.2.0 which some tools still need.
There was a problem hiding this comment.
@michael-valdron I have added 1.5.0 version with the updated image, would you please add the corresponding tag to https://github.com/devfile-samples/devfile-stack-go?
Co-authored-by: Michael Valdron <michael.valdron@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: vinokurig The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Co-authored-by: Michael Valdron <michael.valdron@gmail.com>
2 participants
Description of Changes
Add new go stack version with the new runtime image version
Related Issue(s)
eclipse-che/che#23717
Acceptance Criteria
Have you read the devfile registry contributing guide and followed its instructions?
Does this repository's tests pass with your changes?
Does any documentation need to be updated with your changes?
Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)
Tests Performed
Explain what tests you personally ran to ensure the changes are functioning as expected.
How To Test
Instructions for the reviewer on how to test your changes.
Notes To Reviewer
Any notes you would like to include for the reviewer.