Skip to content

feat(async/unstable): add support for AbortSignal in pooledMap#7014

Open
tomas-zijdemans wants to merge 6 commits intodenoland:mainfrom
tomas-zijdemans:pool-signal
Open

feat(async/unstable): add support for AbortSignal in pooledMap#7014
tomas-zijdemans wants to merge 6 commits intodenoland:mainfrom
tomas-zijdemans:pool-signal

Conversation

@tomas-zijdemans
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Feb 19, 2026

Codecov Report

❌ Patch coverage is 94.68085% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.83%. Comparing base (af9b074) to head (ac26cdd).

Files with missing lines Patch % Lines
async/unstable_pool.ts 94.68% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7014   +/-   ##
=======================================
  Coverage   93.83%   93.83%           
=======================================
  Files         624      625    +1     
  Lines       49629    49723   +94     
  Branches     8721     8748   +27     
=======================================
+ Hits        46571    46660   +89     
- Misses       2478     2482    +4     
- Partials      580      581    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

* @returns The async iterator with the transformed values.
* @throws {RangeError} If `poolLimit` is not a positive integer.
*/
export function pooledMap<T, R>(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm this function signature is incompatible with the existing one. we can't stabilize this version as is. can we somehow invent something else which isn't a breaking change? (maybe we have to use overload?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Goog point! I pushed a new commit using overloads

@kt3k
Copy link
Member

kt3k commented Mar 9, 2026

Ok. Now this works, but also it is something new to std (No API in std is overloaded in this way as far as I'm aware, and is something not covered by the styled guide).

I'd like to here the opinions from other community members

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants