feat(async/unstable): add support for AbortSignal in pooledMap#7014
feat(async/unstable): add support for AbortSignal in pooledMap#7014tomas-zijdemans wants to merge 6 commits intodenoland:mainfrom
pooledMap#7014Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7014 +/- ##
=======================================
Coverage 93.83% 93.83%
=======================================
Files 624 625 +1
Lines 49629 49723 +94
Branches 8721 8748 +27
=======================================
+ Hits 46571 46660 +89
- Misses 2478 2482 +4
- Partials 580 581 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| * @returns The async iterator with the transformed values. | ||
| * @throws {RangeError} If `poolLimit` is not a positive integer. | ||
| */ | ||
| export function pooledMap<T, R>( |
There was a problem hiding this comment.
hmm this function signature is incompatible with the existing one. we can't stabilize this version as is. can we somehow invent something else which isn't a breaking change? (maybe we have to use overload?)
There was a problem hiding this comment.
Goog point! I pushed a new commit using overloads
|
Ok. Now this works, but also it is something new to std (No API in std is overloaded in this way as far as I'm aware, and is something not covered by the styled guide). I'd like to here the opinions from other community members |
No description provided.