Skip to content

ブラウザ版のrankingHistory関数で、fetchOptionsを考慮していなかったのを修正 #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deflis merged 1 commit into from
Jan 11, 2026
Merged

ブラウザ版のrankingHistory関数で、fetchOptionsを考慮していなかったのを修正 #215

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/index.browser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import type NarouNovel from "./narou.js";
import type { ExecuteOptions } from "./narou.js";
import NarouNovelJsonp from "./narou-jsonp.js";
import SearchBuilder from "./search-builder.js";
import SearchBuilderR18 from "./search-builder-r18.js";
Expand Down Expand Up @@ -67,13 +68,16 @@ export function ranking(api: NarouNovel = narouNovelJsonp): RankingBuilder {
/**
* なろう殿堂入り API でランキング履歴を取得する
* @param {string} ncode 小説のNコード
* @param {ExecuteOptions} [options] 実行オプション
* @param {NarouNovel} [api] API実行クラスのインスタンス
Copy link

@gemini-code-assist gemini-code-assist bot Jan 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

JSDocの api パラメータにデフォルト値を記載すると、より分かりやすくなります。JSDocの標準的な記法に従い [api=narouNovelJsonp] のように記述することで、この関数を利用する開発者がIDEのヒントなどでデフォルトの挙動を把握しやすくなります。

Suggested change
* @param {NarouNovel} [api] API実行クラスのインスタンス
* @param {NarouNovel} [api=narouNovelJsonp] API実行クラスのインスタンス

* @see https://dev.syosetu.com/man/rankinapi/
*/
export async function rankingHistory(
ncode: string,
options?: ExecuteOptions,
api: NarouNovel = narouNovelJsonp
): Promise<RankingHistoryResult[]> {
const result = await api.executeRankingHistory({ ncode });
const result = await api.executeRankingHistory({ ncode }, options);
if (Array.isArray(result)) {
return result.map(formatRankingHistory);
} else {
Expand Down
Loading