Exclude the dependencies newer than 3 days#451
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
- Purpose: make CI/tutorial generation and dC sync workflows more reproducible by preventing installs from resolving to very recently published Python packages (intended “newer than 3 days” cutoff; Fixes #448).
Changes:
- Add
uv pip install --exclude-newer P3D ...to multiple workflow install steps. - Migrate
dc_sync.ymlandfull_dc_sync.ymlfrompiptouv+.venvactivation for subsequentpythonruns.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
.github/workflows/verify_generation.yml |
Use uv pip install --exclude-newer P3D during dependency install for generation verification. |
.github/workflows/run_tutorials.yml |
Apply --exclude-newer P3D to nbconvert/ipython and notebook-specific dependency installs. |
.github/workflows/full_dc_sync.yml |
Switch to setup-uv, create .venv, install with --exclude-newer P3D, and activate venv for script execution. |
.github/workflows/dc_sync.yml |
Switch to setup-uv, create .venv, install with --exclude-newer P3D, and activate venv before generating upload artifacts. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+22
to
+24
| run: | | ||
| uv venv | ||
| uv pip install -r requirements.txt | ||
| uv pip install --exclude-newer P3D -r requirements.txt |
Comment on lines
+93
to
+100
| uv pip install "haystack-ai==${VERSION#v}" | ||
| fi | ||
| uv pip install nbconvert ipython | ||
| uv pip install --exclude-newer P3D nbconvert ipython |
Comment on lines
99
to
106
| fi | ||
| uv pip install nbconvert ipython | ||
| uv pip install --exclude-newer P3D nbconvert ipython | ||
| - name: Install tutorial dependencies | ||
| if: toJSON(matrix.dependencies) != '[]' | ||
| run: | | ||
| uv pip install "${{ join(matrix.dependencies, '" "')}}" | ||
| uv pip install --exclude-newer P3D "${{ join(matrix.dependencies, '" "')}}" | ||
Comment on lines
+18
to
+21
| - name: Install requirements | ||
| run: | | ||
| pip install --upgrade pip | ||
| pip install -r requirements.txt | ||
| uv venv | ||
| uv pip install --exclude-newer P3D -r requirements.txt |
Comment on lines
+54
to
+57
| - name: Install requirements | ||
| run: | | ||
| pip install --upgrade pip | ||
| pip install -r requirements.txt | ||
| uv venv | ||
| uv pip install --exclude-newer P3D -r requirements.txt |
bilgeyucel
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #448