Skip to content

feat: Update WatsonXChatGenerator to use the StreamingChunk fields#2902

Draft
maxdswain wants to merge 2 commits intodeepset-ai:mainfrom
maxdswain:watsonxchatgenerator-streamingchunk
Draft

feat: Update WatsonXChatGenerator to use the StreamingChunk fields#2902
maxdswain wants to merge 2 commits intodeepset-ai:mainfrom
maxdswain:watsonxchatgenerator-streamingchunk

Conversation

@maxdswain
Copy link
Contributor

Related Issues

Proposed Changes:

feat: Update WatsonXChatGenerator to use the StreamingChunk index and finish_reason fields.

How did you test it?

Updated existing tests.

Notes for the reviewer

Checklist

@maxdswain maxdswain requested a review from a team as a code owner March 1, 2026 18:17
@maxdswain maxdswain requested review from anakin87 and removed request for a team March 1, 2026 18:17
@github-actions github-actions bot added integration:watsonx type:documentation Improvements or additions to documentation labels Mar 1, 2026
Copy link
Member

@anakin87 anakin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

I think that a little more adaptation work will be needed, especially in handling tool calls.

I suggest taking inspiration from #2078 and #2108 (but keeping in mind that each provider has its own particularities and code can be very different).

Also, I'd like to see a test with real chunks coming from WatsonX (similar test for Google GenAI).

@maxdswain
Copy link
Contributor Author

Thanks for the contribution!

I think that a little more adaptation work will be needed, especially in handling tool calls.

I suggest taking inspiration from #2078 and #2108 (but keeping in mind that each provider has its own particularities and code can be very different).

Also, I'd like to see a test with real chunks coming from WatsonX (similar test for Google GenAI).

Okay, I'll convert it to a draft for now and work on it a bit more to add support for tool calls as well as more tests. I'll let you know when it's ready.

@maxdswain maxdswain marked this pull request as draft March 5, 2026 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration:watsonx type:documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: Update WatsonXChatGenerator to use the StreamingChunk fields

2 participants