feat: Update WatsonXChatGenerator to use the StreamingChunk fields#2902
feat: Update WatsonXChatGenerator to use the StreamingChunk fields#2902maxdswain wants to merge 2 commits intodeepset-ai:mainfrom
WatsonXChatGenerator to use the StreamingChunk fields#2902Conversation
anakin87
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
I think that a little more adaptation work will be needed, especially in handling tool calls.
I suggest taking inspiration from #2078 and #2108 (but keeping in mind that each provider has its own particularities and code can be very different).
Also, I'd like to see a test with real chunks coming from WatsonX (similar test for Google GenAI).
Okay, I'll convert it to a draft for now and work on it a bit more to add support for tool calls as well as more tests. I'll let you know when it's ready. |
Related Issues
WatsonXChatGeneratorto use theStreamingChunkfields #2217 & feat: Update our ChatGenerators in integrations to use the new StreamingChunk fields #2070Proposed Changes:
feat: Update
WatsonXChatGeneratorto use theStreamingChunkindexandfinish_reasonfields.How did you test it?
Updated existing tests.
Notes for the reviewer
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.