ci: suppress LeakSanitizer SEGV in TensorFlow/MLIR/LLVM stack#5301
ci: suppress LeakSanitizer SEGV in TensorFlow/MLIR/LLVM stack#5301njzjz-bot wants to merge 2 commits intodeepmodeling:masterfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughAdds a LeakSanitizer suppression entry to Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/suppr.txt:
- Line 10: The suppression entry for ThreadRegistry::GetThreadLocked is missing
the required LeakSanitizer prefix; update the suppression pattern to include the
"leak:" prefix (i.e., change the entry referencing
ThreadRegistry::GetThreadLocked so it reads
leak:ThreadRegistry::GetThreadLocked) so the leak suppression is recognized;
locate the existing suppression list and modify the
ThreadRegistry::GetThreadLocked line accordingly.
- Around line 6-10: The suppression entry for ThreadRegistry::GetThreadLocked is
missing the required LSan type prefix; update the line containing the symbol
ThreadRegistry::GetThreadLocked to include the "leak:" prefix (i.e., change it
to leak:ThreadRegistry::GetThreadLocked) so it matches the other suppressions
and conforms to LSan suppression syntax.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 68213295-d3e1-426b-b921-fc4309dca3b1
📒 Files selected for processing (1)
.github/workflows/suppr.txt
|
Fix: LSAN suppression file requires a type prefix (e.g. 'leak:'). Previous commit had a bare symbol line which caused . Updated suppression to: so it parses correctly. |
|
Follow-up (shell quoting fix): the suppression file must contain entries of form |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5301 +/- ##
==========================================
- Coverage 82.32% 82.32% -0.01%
==========================================
Files 768 768
Lines 77098 77097 -1
Branches 3659 3659
==========================================
- Hits 63469 63468 -1
+ Misses 12458 12457 -1
- Partials 1171 1172 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Authored by OpenClaw (model: gpt-5.2)
Authored by OpenClaw (model: gpt-5.2)
2ae86df to
7de0d2d
Compare
|
It seems that the error in #5300 is occasional, and cannot be reproduced again. Thus, I decide to close this PR since I cannot validate whether this PR fixes something. |
LeakSanitizer SEGVs during stack unwinding on certain TensorFlow/MLIR/LLVM operations (ThreadRegistry::GetThreadLocked). This appears to be an upstream issue in libsanitizer when handling complex thread topologies or late allocations.
Adding a suppression for the crashing function to treat this as a known CI flake and prevent job failure.
Crash Log:
Summary by CodeRabbit