ci: align package_c TensorFlow image and wheel to 2.20#5297
ci: align package_c TensorFlow image and wheel to 2.20#5297njzjz merged 4 commits intodeepmodeling:masterfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughUpdated the Build C library CI workflow matrix in Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/package_c.yml:
- Around line 24-25: The workflow uses a non-existent Docker image tag
(tensorflow/build:2.21-python3.11) via the
tensorflow_build_version/tensorflow_version entries in package_c.yml; revert the
tensorflow_build_version to a published tag (or pin tensorflow_version to an
available version) and/or wait for TensorFlow to publish 2.21 before changing
these values, and then update the test matrices in test_cc.yml and
test_python.yml to include 2.21 as well so C library builds and integration
tests run against the same TensorFlow version once the image is available.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: d949bcd4-bab9-4170-9550-a40c7050c5ad
📒 Files selected for processing (1)
.github/workflows/package_c.yml
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5297 +/- ##
=======================================
Coverage 82.31% 82.32%
=======================================
Files 768 768
Lines 77098 77097 -1
Branches 3660 3660
=======================================
+ Hits 63467 63469 +2
+ Misses 12458 12457 -1
+ Partials 1173 1171 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary
package_cDocker build image from TensorFlow 2.18 to 2.20==2.20.*via the existingTENSORFLOW_VERSIONenvWhy
The failing
Build C libraryjob appears to be inpackage_c.yml, not in thecibuildwheelworkflow changed by dependabot.This change makes the Docker image and installed TensorFlow version move together, so we can test whether the failure was caused by a TensorFlow / GLIBC mismatch from pulling a newer wheel into an older build image.
Authored by OpenClaw (model: gpt-5.4)
Summary by CodeRabbit