feat(ui): DH-19818: add nested dashboard support#1302
Open
mofojed wants to merge 11 commits intodeephaven:mainfrom
Open
feat(ui): DH-19818: add nested dashboard support#1302mofojed wants to merge 11 commits intodeephaven:mainfrom
mofojed wants to merge 11 commits intodeephaven:mainfrom
Conversation
- Dashboard component now detects when inside a panel and delegates to NestedDashboard - NestedDashboard uses DHCDashboard from @deephaven/dashboard to create isolated GoldenLayout - NestedDashboardContent provides context providers for nested panels - DashboardContent extracted for top-level dashboard rendering - Add E2E tests and Python test fixtures for nested dashboards - Add unit tests for Dashboard and NestedDashboard components DH-19818
- Just using usePersistentState and it seems to work - Sometimes the nested dashboards don't load correctly, seems to be an intermittent issue/some sort of race condition. Will debug later, after writing docs
- Update rules to clarify root-level vs nested dashboard restrictions - Update bottom-level section to reference nested dashboards - Add Nested Dashboards section with examples to dashboard.md - Add Nested Dashboards section to creating-dashboards.md guide - Add example for sharing state between nested dashboards
mofojed
force-pushed
the
DH-19818-nested-dashboards
branch
from
1be29b1 to
6b71ddb
Compare
mofojed
requested review from
a team,
dsmmcken,
jnumainville and
vbabich
and removed request for
a team
|
ui docs preview (Available for 14 days) |
- Separated into its own PR: deephaven#1303
|
ui docs preview (Available for 14 days) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NestedDashboardNestedDashboardusesDashboardfrom@deephaven/dashboardto create isolated layoutNestedDashboardContentprovides context providers for nested panelsDashboardContentextracted for top-level dashboard renderingDashboardandNestedDashboardcomponents