add Bitget exchange adapter #3430

karamble · 2025-12-01T22:15:13Z

This commit adds full support for Bitget centralized exchange integration to the market maker, including REST API and WebSocket v2 implementations for trading, orderbook synchronization, balance management, and deposit/ withdrawal operations.

Key features:

Complete Bitget CEX adapter implementation (client/mm/libxc/bitget.go)
WebSocket v2 support for real-time orderbook updates and order status
Market data retrieval with proper ticker handling and grouping by Slug
Order placement, cancellation, and status tracking
Balance fetching and deposit/withdrawal operations
Checksum validation for orderbook integrity
Order status check before cancellation to prevent unnecessary API calls

Configuration changes:

Add APIPassphrase field to CEXConfig for exchanges requiring passphrase authentication (Bitget requires this in addition to API key/secret)
Extend CEXConfig interface in libxc to support passphrase
Update frontend forms and UI to handle passphrase input for Bitget
Add Bitget logo and display information to UI

Bug fixes:

Fix omitempty JSON tag behavior for CEXBaseID and CEXQuoteID in BotConfig to properly handle asset ID 0 (BTC). Previously, these fields were omitted from JSON when their value was 0, causing frontend errors when loading bot configurations for BTC markets.
Add normalization logic in mm.go to ensure CEXBaseID and CEXQuoteID are always set when CEXName is configured, preventing missing config data for assets with ID 0. Normalization is applied:
- When loading configs from disk (NewMarketMaker, getMarketMakingConfig)
- When accessing default config (defaultConfig)
- When retrieving configs for markets (configsForMarket)
- Before saving configs (updateDefaultBotConfig)

Order status handling:

Implement correct Bitget order status codes (live, partially_filled, filled, cancelled) matching Spot Trading API documentation
Add status check in CancelTrade to verify order completion before attempting cancellation, preventing unnecessary API calls and errors
Fix TradeStatus to handle array response from Bitget API

Files changed:

client/mm/libxc/bitget.go (new file - complete adapter implementation)
client/mm/libxc/bgtypes/ (new package - Bitget API types)
client/mm/libxc/interface.go (add Bitget constant and passphrase support)
client/mm/config.go (add APIPassphrase, fix omitempty tags for CEXBaseID/CEXQuoteID)
client/mm/mm.go (add passphrase handling, normalization logic)
client/webserver/site/src/js/registry.ts (add passphrase to CEXConfig)
client/webserver/site/src/js/forms.ts (add passphrase UI handling)
client/webserver/site/src/js/mmutil.ts (add Bitget display info)
client/webserver/site/src/html/forms.tmpl (add passphrase input field)
client/webserver/locales/*.go (add passphrase translations)
client/webserver/site/src/img/bitget.com.png (new file - Bitget logo)

This commit adds full support for Bitget centralized exchange integration to the market maker, including REST API and WebSocket v2 implementations for trading, orderbook synchronization, balance management, and deposit/ withdrawal operations. Key features: - Complete Bitget CEX adapter implementation (client/mm/libxc/bitget.go) - WebSocket v2 support for real-time orderbook updates and order status - Market data retrieval with proper ticker handling and grouping by Slug - Order placement, cancellation, and status tracking - Balance fetching and deposit/withdrawal operations - Checksum validation for orderbook integrity - Order status check before cancellation to prevent unnecessary API calls Configuration changes: - Add APIPassphrase field to CEXConfig for exchanges requiring passphrase authentication (Bitget requires this in addition to API key/secret) - Extend CEXConfig interface in libxc to support passphrase - Update frontend forms and UI to handle passphrase input for Bitget - Add Bitget logo and display information to UI Bug fixes: - Fix omitempty JSON tag behavior for CEXBaseID and CEXQuoteID in BotConfig to properly handle asset ID 0 (BTC). Previously, these fields were omitted from JSON when their value was 0, causing frontend errors when loading bot configurations for BTC markets. - Add normalization logic in mm.go to ensure CEXBaseID and CEXQuoteID are always set when CEXName is configured, preventing missing config data for assets with ID 0. Normalization is applied: * When loading configs from disk (NewMarketMaker, getMarketMakingConfig) * When accessing default config (defaultConfig) * When retrieving configs for markets (configsForMarket) * Before saving configs (updateDefaultBotConfig) Order status handling: - Implement correct Bitget order status codes (live, partially_filled, filled, cancelled) matching Spot Trading API documentation - Add status check in CancelTrade to verify order completion before attempting cancellation, preventing unnecessary API calls and errors - Fix TradeStatus to handle array response from Bitget API Files changed: - client/mm/libxc/bitget.go (new file - complete adapter implementation) - client/mm/libxc/bgtypes/ (new package - Bitget API types) - client/mm/libxc/interface.go (add Bitget constant and passphrase support) - client/mm/config.go (add APIPassphrase, fix omitempty tags for CEXBaseID/CEXQuoteID) - client/mm/mm.go (add passphrase handling, normalization logic) - client/webserver/site/src/js/registry.ts (add passphrase to CEXConfig) - client/webserver/site/src/js/forms.ts (add passphrase UI handling) - client/webserver/site/src/js/mmutil.ts (add Bitget display info) - client/webserver/site/src/html/forms.tmpl (add passphrase input field) - client/webserver/locales/*.go (add passphrase translations) - client/webserver/site/src/img/bitget.com.png (new file - Bitget logo)

JoeGruffins

Lots of code to review but looks good to me. A few things that stand out.

Saving the book as strings and then parsing many of them many times every update does not seem optimal.
I don't think it is necessary to check the checksum. Am I wrong?
There are many ignored errors, especially for parsing floats. Please check and log all errors. It prevents alot of headaches later to just stick to that rule, unless absolutely not necessary. Even then best to comment why it is absolutely not needed.

JoeGruffins · 2025-12-11T03:01:55Z

client/mm/libxc/bitget.go

+		if !found && qty != "0" {
+			sob.asks = sob.insertAsk(price, qty)
+		}
+	}


These two could be combined for less code but it's fine not to change.

JoeGruffins · 2025-12-11T03:04:19Z

client/mm/libxc/bitget.go

+// insertBid inserts a bid maintaining descending price order
+func (sob *stringOrderbook) insertBid(price, qty string) [][]string {
+	priceFloat, _ := strconv.ParseFloat(price, 64)
+	newBid := []string{price, qty}
+
+	for i, level := range sob.bids {
+		levelPrice, _ := strconv.ParseFloat(level[0], 64)
+		if priceFloat > levelPrice {
+			// Insert here
+			return append(sob.bids[:i], append([][]string{newBid}, sob.bids[i:]...)...)
+		}
+	}
+	// Append at end
+	return append(sob.bids, newBid)
+}


Seems really inefficient to parse everything every time rather than just converting once and saving as a float.

There's probably a better structure to save these in as well. Unsure atm though. I guess can optimize later.

JoeGruffins · 2025-12-11T03:32:59Z

client/mm/libxc/bitget.go

+		bids, asks, err := b.convertBookUpdate(update)
+		if err != nil {
+			b.log.Errorf("%s: error converting book update: %v", b.symbol, err)
+			return false
+		}
+
+		// Sanity check: Validate rate > 0 (qty=0 is valid for removals)
+		for _, bid := range bids {
+			if bid.rate == 0 {
+				b.log.Errorf("%s: Invalid bid with zero rate: rate=%d, qty=%d", b.symbol, bid.rate, bid.qty)
+				return false
+			}
+		}
+		for _, ask := range asks {
+			if ask.rate == 0 {
+				b.log.Errorf("%s: Invalid ask with zero rate: rate=%d, qty=%d", b.symbol, ask.rate, ask.qty)
+				return false
+			}
+		}


Converting all the books just to look at the rate and then throwing those away seems wild.

JoeGruffins · 2025-12-11T03:36:32Z

client/mm/libxc/bitget.go

+		// Mark uint64 cache as dirty (will rebuild on next read)
+		b.bookDirty.Store(true)
+
+		// Validate checksum (if provided and non-zero)


Why do we need to validate the checksum? Doesn't seem to serve a purpose. I think this should be removed. Can leave some comments noting it is possible... Do their docs say you should do this?

JoeGruffins · 2025-12-11T03:41:27Z

client/mm/libxc/bitget.go

+		processUpdate := func(update *bgtypes.BookUpdate) bool {
+			syncMtx.Lock()
+			defer syncMtx.Unlock()
+			return acceptUpdate(update, update.IsSnapshot)


No need to use two arguments if one is part of the update struct.

JoeGruffins · 2025-12-11T05:05:54Z

client/mm/libxc/bitget.go

+		price, _ := strconv.ParseFloat(item[0], 64)
+		qty, _ := strconv.ParseFloat(item[1], 64)


Please log errors.

JoeGruffins · 2025-12-11T05:07:44Z

client/mm/libxc/bitget.go

+		if err != nil {
+			continue
+		}


Can log error?

JoeGruffins · 2025-12-11T05:14:42Z

client/mm/libxc/bitget.go

+			high24h, _ := strconv.ParseFloat(ticker.High24h, 64)
+			low24h, _ := strconv.ParseFloat(ticker.Low24h, 64)
+			close, _ := strconv.ParseFloat(ticker.Close, 64)
+			quoteVol, _ := strconv.ParseFloat(ticker.QuoteVol, 64)
+			baseVol, _ := strconv.ParseFloat(ticker.BaseVol, 64)
+			openUtc, _ := strconv.ParseFloat(ticker.OpenUtc, 64)
+			changeUtc24h, _ := strconv.ParseFloat(ticker.ChangeUtc24h, 64)


Rather not ignore errors.

JoeGruffins · 2025-12-11T05:26:09Z

client/mm/libxc/bitget.go

+	size, _ := strconv.ParseFloat(orderDetail.Size, 64)
+	baseFilled, _ := strconv.ParseFloat(orderDetail.BaseVolume, 64)
+	quoteFilled, _ := strconv.ParseFloat(orderDetail.QuoteVolume, 64)
+	priceAvg, _ := strconv.ParseFloat(orderDetail.PriceAvg, 64)


Rather not ignore errors.

JoeGruffins · 2025-12-11T05:33:03Z

client/mm/libxc/bitget.go

+					return 0, "", ErrWithdrawalPending
+				}
+
+				sizeFloat, _ := strconv.ParseFloat(status.Size, 64)


Rather not ignore error.

JoeGruffins reviewed Dec 11, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

add Bitget exchange adapter #3430

add Bitget exchange adapter #3430

Uh oh!

karamble commented Dec 1, 2025

Uh oh!

JoeGruffins left a comment •

edited

Loading

Uh oh!

JoeGruffins Dec 11, 2025

Uh oh!

JoeGruffins Dec 11, 2025

Uh oh!

JoeGruffins Dec 11, 2025

Uh oh!

JoeGruffins Dec 11, 2025

Uh oh!

JoeGruffins Dec 11, 2025

Uh oh!

JoeGruffins Dec 11, 2025

Uh oh!

JoeGruffins Dec 11, 2025

Uh oh!

JoeGruffins Dec 11, 2025

Uh oh!

JoeGruffins Dec 11, 2025

Uh oh!

JoeGruffins Dec 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		price, _ := strconv.ParseFloat(item[0], 64)
		qty, _ := strconv.ParseFloat(item[1], 64)

add Bitget exchange adapter #3430

Are you sure you want to change the base?

add Bitget exchange adapter #3430

Uh oh!

Conversation

karamble commented Dec 1, 2025

Uh oh!

JoeGruffins left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

JoeGruffins left a comment •

edited

Loading