ui: MMSettings rewrite using react #3354
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
martonp
force-pushed
the
reactMMSettings
branch
3 times, most recently
from
f68a05a to
cc3db02
Compare
karamble
added a commit
to karamble/dcrdex
that referenced
this pull request
Oct 23, 2025
go tidy adds protobuf dependency for websocket data parsing of mexc api Depends on: decred#3354
martonp
force-pushed
the
reactMMSettings
branch
from
cc3db02 to
c061e3a
Compare
martonp
changed the title
JoeGruffins
approved these changes
Oct 31, 2025
Member
JoeGruffins
left a comment
JoeGruffins
left a comment
There was a problem hiding this comment.
Looks good to me. I left some comments on #3367 do they look valid? Can merge this and fix after as well.
karamble
added a commit
to karamble/dcrdex
that referenced
this pull request
Nov 3, 2025
go tidy adds protobuf dependency for websocket data parsing of mexc api Depends on: decred#3354
karamble
added a commit
to karamble/dcrdex
that referenced
this pull request
Nov 6, 2025
go tidy adds protobuf dependency for websocket data parsing of mexc api Depends on: decred#3354
Member
|
The mexc commit is in so maybe need to rebase this? |
Member
|
I'm going to rewrite the entire UI in React, so this will probably never be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rewrite of the MMSettings page using react.