chore(vm): more messages about cpu and memory hotplug fails#2406
Open
diafour wants to merge 4 commits into
Open
chore(vm): more messages about cpu and memory hotplug fails#2406diafour wants to merge 4 commits into
diafour wants to merge 4 commits into
Conversation
Contributor
LopatinDmitr
left a comment
LopatinDmitr
left a comment
There was a problem hiding this comment.
Please add tests for negative cases
- Do not start live migration to apply cpu or memory changes with hotplug if VM is NonMigratable. - Fix sync_kvvm_test: fill PrintableStatus for kvvm as it is required to detect if disruptive changes may be applied. - Add test for Upgrade*ChangesToRestart mutators. Signed-off-by: Ivan Mikheykin <ivan.mikheykin@flant.com>
Signed-off-by: Ivan Mikheykin <ivan.mikheykin@flant.com>
Signed-off-by: Ivan Mikheykin <ivan.mikheykin@flant.com>
…n for NonMigratable VM" test Signed-off-by: Ivan Mikheykin <ivan.mikheykin@flant.com>
diafour
force-pushed
the
fix/vm/hotplug-add-more-messages-when-migration-fails
branch
from
614bda2 to
58b1aed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Why do we need it, and what problem does it solve?
No need to run live migration if VM is NonMigratable, backoff to RequireRestart.
What is the expected result?
CPU and memory changes are always require restart if VM in NonMigratable.
Checklist
Changelog entries