test(test): simplify lsblk size lookup#2405
Merged
Merged
Conversation
6be7cbc to
4e245d5
Compare
4e245d5 to
9adfa6b
Compare
Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com>
9adfa6b to
8508a40
Compare
hardcoretime
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Simplify disk size lookup in the
VirtualDiskResizinge2e test.The test now uses a single
lsblk --nodeps --json -o SERIAL,SIZEcall and selects the required block device by serial from JSON output, instead of first resolving the device path and then running a secondlsblkcommand for size.Why do we need it, and what problem does it solve?
VirtualDiskResizingcould fail while probing disk sizes because the previous implementation executed multiple SSH commands withlsblk/grep/awk. Under hotplug/resize activity this made the check more fragile and increased the chance of timeout-relatedsignal: killederrors.Using one simple JSON-based
lsblkcall reduces the amount of SSH work and avoids shell parsing for device path lookup.What is the expected result?
VirtualDiskResizinge2e test.test/e2elint reports no issues.Checklist
Changelog entries